From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kim Phillips Date: Tue, 25 Mar 2008 10:42:11 -0500 Subject: [U-Boot-Users] [PATCH 6/7] 83xx/fdt_support: let user specifiy FSL USB Dual-Role controller role In-Reply-To: <20080325134854.GA25951@localhost.localdomain> References: <20080314202018.GF22581@localhost.localdomain> <20080319203558.cdd4be6f.kim.phillips@freescale.com> <20080324144419.GA30190@localhost.localdomain> <20080324180049.73f2f60b.kim.phillips@freescale.com> <20080325134854.GA25951@localhost.localdomain> Message-ID: <20080325104211.dbc40a03.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 25 Mar 2008 16:48:54 +0300 Anton Vorontsov wrote: > On Mon, Mar 24, 2008 at 06:00:49PM -0500, Kim Phillips wrote: > > On Mon, 24 Mar 2008 17:44:19 +0300 > > Anton Vorontsov wrote: > > > > > On Wed, Mar 19, 2008 at 08:35:58PM -0500, Kim Phillips wrote: > > > > On Fri, 14 Mar 2008 23:20:18 +0300 > > > > Anton Vorontsov wrote: > > > > > > > > > > > > > diff --git a/include/fdt_support.h b/include/fdt_support.h > > > > > index 7836f28..c10de8a 100644 > > > > > --- a/include/fdt_support.h > > > > > +++ b/include/fdt_support.h > > > > > @@ -50,6 +50,12 @@ int fdt_find_and_setprop(void *fdt, const char *node, const char *prop, > > > > > const void *val, int len, int create); > > > > > void fdt_fixup_qe_firmware(void *fdt); > > > > > > > > > > +#ifdef CONFIG_HAS_FSL_DR_USB > > > > > +void fdt_fixup_dr_usb(void *blob, bd_t *bd); > > > > > +#else > > > > > +static inline void fdt_fixup_dr_usb(void *blob, bd_t *bd) {} > > > > > +#endif /* CONFIG_HAS_FSL_DR_USB */ > > > > > + > > > > > > > > this looks like a prime candidate for a weak function (which would also > > > > eliminate the need for the new CONFIG_HAS_FSL_DR_USB introduced here). > > > > > > Are you sure it's supposed to work like this?.. I don't see the linker > > > dropping unused weak symbols with the patch below. > > > > with something like the following I get 24 bytes more text in > > fdt_support.o, and 200 total bytes added 83xx-wide: > > > [...] > > but the QE based 83xx SoCs don't use this fixup. So while > > CONFIG_HAS_FSL_DR_USB gives you more control, I doubt saving 200 bytes > > justifies the new config either. Either way really, but I tend to be > > against any new CONFIG_s. > > Hm... maybe then it's better to place fdt_fixup_usb_dr function > inside the fdt_support.h, marking it with static inline -- it's used > just once per board anyway..? Then neither space wasted nor the new > configs introduced. I'd like to see that. Do you want to send a patch? Kim