From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 26 Mar 2008 11:14:34 +0100 Subject: [U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function In-Reply-To: <20080326110618.530c1e82@hskinnemo-gx620.norway.atmel.com> References: <200803221114.40956.sr@denx.de> <200803250804.13314.sr@denx.de> <20080326110618.530c1e82@hskinnemo-gx620.norway.atmel.com> Message-ID: <200803261114.34582.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 26 March 2008, Haavard Skinnemoen wrote: > > Using Markus's idea, why not use a cpu (platform) specific *and* a board > > specific init function, both with an empty weak alias in the common eth.c > > code: > > > > cpu_eth_init(bis); > > board_eth_init(bis); > > Why? > > The whole point about this exercise is to get rid of board-specific > knowledge in the common code. What is the purpose of cpu_eth_init()? Because on PPC4xx for example, all boards are using exactly the same eth_init code (for the SoC interfaces). And I don't like adding this code to more than 80 boards. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================