From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 26 Mar 2008 11:34:08 +0100 Subject: [U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function In-Reply-To: <20080326112538.006f569b@hskinnemo-gx620.norway.atmel.com> References: <200803221114.40956.sr@denx.de> <200803261114.34582.sr@denx.de> <20080326112538.006f569b@hskinnemo-gx620.norway.atmel.com> Message-ID: <200803261134.08925.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 26 March 2008, Haavard Skinnemoen wrote: > > Because on PPC4xx for example, all boards are using exactly the same > > eth_init code (for the SoC interfaces). And I don't like adding this code > > to more than 80 boards. > > All 80 boards have exactly the same ethernet interface (i.e. same kind > of PHY, same MII address, etc.)? Yes, same SoC ethernet interfaces. Currently PHY address etc is configured via config options. > Can't you just add a weak definition of board_eth_init() in the CPU > code then? No. The weak definition is already in net/eth.c. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================