From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 26 Mar 2008 13:39:56 +0100 Subject: [U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function In-Reply-To: <20080326131915.4bed3082@hskinnemo-gx620.norway.atmel.com> References: <200803221114.40956.sr@denx.de> <200803261243.51429.sr@denx.de> <20080326131915.4bed3082@hskinnemo-gx620.norway.atmel.com> Message-ID: <200803261339.56946.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 26 March 2008, Haavard Skinnemoen wrote: > > I could use board_eth_init() as a common PPC4xx platform code. But I > > would loose the chance being able to implement a "real" board specific > > board_eth_init() for some boards in the future then. > > Yeah...it would be bad to prevent future boards from doing the right > thing... :) > How about you do an internal split in cpu/ppc4xx/4xx_enet.c first, > placing the truly platform-specfic bits in a separate function that can > be called by "new-style" boards, and the board-specific bits in > board_eth_init(), serving as a wrapper around the platform-specific > init function, with as many #ifdefs as needed in order to handle the > existing differences between the boards. This function could be > conditional on CONFIG_PPC4XX_LEGACY_BOARD_ETH_INIT or something so that > boards can be migrated to the new API one by one. Good idea, but unfortunately I have no time to do this in the next few days/weeks. So no basic rework of the 4xx emac init code in this merge window. At least not from me. Patches as always welcome. :) > U-Boot could really use a Janitor team ;-) ;) Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================