* [U-Boot-Users] [PATCH] PPC405EP Set EMAC noise filter bits
@ 2008-03-20 7:22 Markus Brunner
2008-03-27 9:49 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Markus Brunner @ 2008-03-20 7:22 UTC (permalink / raw)
To: u-boot
This bug was introduced with commit aee747f19b460a0e9da20ff21e90fdaac1cec359
which enabled CFG_4xx_GPIO_TABLE for PPC405 and unintentionally
disabled the setting of the emac noise filter bits for PPC405EP when CFG_4xx_GPIO_TABLE is set.
Signed-off-by: Markus Brunner <super.firetwister@gmail.com>
---
diff --git a/cpu/ppc4xx/cpu_init.c b/cpu/ppc4xx/cpu_init.c
index 5d15e2f..5ed439d 100644
--- a/cpu/ppc4xx/cpu_init.c
+++ b/cpu/ppc4xx/cpu_init.c
@@ -135,6 +135,7 @@ cpu_init_f (void)
#if defined (CFG_GPIO0_TCR)
out32(GPIO0_TCR, CFG_GPIO0_TCR); /* enable output driver for outputs */
#endif
+#endif /* CONFIG_405E? !CFG_4xx_GPIO_TABLE */
#if defined (CONFIG_405EP)
/*
@@ -147,7 +148,6 @@ cpu_init_f (void)
*/
mtdcr(cpc0_pci, mfdcr(cpc0_pci) | CPC0_PCI_HOST_CFG_EN | CPC0_PCI_ARBIT_EN);
#endif /* CONFIG_405EP */
-#endif /* CONFIG_405EP */
#if defined(CFG_4xx_GPIO_TABLE)
gpio_set_chip_configuration();
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot-Users] [PATCH] PPC405EP Set EMAC noise filter bits
2008-03-20 7:22 [U-Boot-Users] [PATCH] PPC405EP Set EMAC noise filter bits Markus Brunner
@ 2008-03-27 9:49 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2008-03-27 9:49 UTC (permalink / raw)
To: u-boot
On Thursday 20 March 2008, Markus Brunner wrote:
> This bug was introduced with commit
> aee747f19b460a0e9da20ff21e90fdaac1cec359 which enabled CFG_4xx_GPIO_TABLE
> for PPC405 and unintentionally
> disabled the setting of the emac noise filter bits for PPC405EP when
> CFG_4xx_GPIO_TABLE is set.
>
> Signed-off-by: Markus Brunner <super.firetwister@gmail.com>
Applied to u-boot-ppc4xx locally. Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-27 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-20 7:22 [U-Boot-Users] [PATCH] PPC405EP Set EMAC noise filter bits Markus Brunner
2008-03-27 9:49 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox