public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c
Date: Thu, 27 Mar 2008 15:56:30 +0100	[thread overview]
Message-ID: <20080327145630.D93EC248BE@gemini.denx.de> (raw)
In-Reply-To: Your message of "Thu, 27 Mar 2008 09:46:23 EST." <47EBB33F.9000308@freescale.com>

In message <47EBB33F.9000308@freescale.com> you wrote:
>
> I suggest that you get rid of the #ifdef and always define i2c1_clk.  The value
> will be set to 0 on systems that don't have an I2C.  I'm planning on submitting
> patches to asm-ppc/global_data.h to get rid of a bunch of #ifdefs because it's
> getting too messy.

Make sure you don't increase the size of the global data by such
pataches. This is critical on some systems.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada

  reply	other threads:[~2008-03-27 14:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 22:45 [U-Boot-Users] [PATCH] Add support for setting the I2C bus speed in fsl_i2c.c Timur Tabi
2008-03-15  7:35 ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-15 21:27   ` Timur Tabi
2008-03-26 15:39 ` Timur Tabi
2008-03-26 16:36   ` Andy Fleming
2008-03-26 23:12 ` Wolfgang Denk
2008-03-27 14:33   ` Timur Tabi
2008-03-27  9:11 ` Luigi 'Comio' Mantellini
2008-03-27  9:45   ` Luigi 'Comio' Mantellini
2008-03-27 14:46     ` Timur Tabi
2008-03-27 14:56       ` Wolfgang Denk [this message]
2008-03-27 17:30       ` Liew Tsi Chung
2008-03-27 17:50         ` Timur Tabi
2008-03-27 18:42           ` Liew Tsi Chung
2008-04-14  1:09             ` Wolfgang Denk
2008-04-14  1:09     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327145630.D93EC248BE@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox