From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix 8xx build to conditionally compile fdt.o
Date: Sat, 29 Mar 2008 22:06:31 -0400 [thread overview]
Message-ID: <20080330020631.GA3868@cideas.com> (raw)
Change to COBJS-y method so that the fdt.o library can be properly
conditionally compiled. Without this change, the mpc8xx boards that
don't use CONFIG_OF_LIBFDT still build the fdt.o, causing code bloat
and compile warnings.
Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
---
Hi Wolfgang,
Commit a6f5f317cd074bbbfa2aab4fca05904c811c19fb added fdt.o unconditionally.
8xx : Add OF support to Adder875 board port - resubmit
I don't have any 8xx boards (especially no Adder boards) so I cannot
verify the patch doesn't break the boards, but it does compile cleanly
both with and w/o CONFIG_OF_LIBFDT.
Best regards,
gvb
cpu/mpc8xx/Makefile | 24 +++++++++++++++++++-----
1 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/cpu/mpc8xx/Makefile b/cpu/mpc8xx/Makefile
index dbdc2e0..a800210 100644
--- a/cpu/mpc8xx/Makefile
+++ b/cpu/mpc8xx/Makefile
@@ -28,14 +28,28 @@ include $(TOPDIR)/config.mk
LIB = $(obj)lib$(CPU).a
START = start.o kgdb.o
-COBJS = bedbug_860.o commproc.o cpu.o cpu_init.o \
- fec.o fdt.o i2c.o interrupts.o lcd.o scc.o \
- serial.o speed.o spi.o \
- traps.o upatch.o video.o
+
+COBJS-y += bedbug_860.o
+COBJS-y += commproc.o
+COBJS-y += cpu.o
+COBJS-y += cpu_init.o
+COBJS-y += fec.o
+COBJS-y += i2c.o
+COBJS-y += lcd.o
+COBJS-y += interrupts.o
+COBJS-y += scc.o
+COBJS-y += serial.o
+COBJS-y += speed.o
+COBJS-y += spi.o
+COBJS-y += traps.o
+COBJS-y += upatch.o
+COBJS-y += video.o
+COBJS-$(CONFIG_OF_LIBFDT) += fdt.o
+
SOBJS = plprcr_write.o
SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS))
+OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
START := $(addprefix $(obj),$(START))
all: $(obj).depend $(START) $(LIB)
--
1.5.4.1
next reply other threads:[~2008-03-30 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 2:06 Jerry Van Baren [this message]
2008-04-14 1:09 ` [U-Boot-Users] [PATCH] Fix 8xx build to conditionally compile fdt.o Wolfgang Denk
2008-04-14 3:31 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080330020631.GA3868@cideas.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox