[U-Boot-Users] [PATCH] bugfix: the watchdog post for lwmon5

[Wolfgang Denk <wd@denx.de>]

In message <20080401083320.B918D24544@gemini.denx.de> I wrote:
>
> >  		/* 3.2.2. strobe watchdog once */
> >  		WATCHDOG_RESET();
> > +		base = post_time_ms (0);
> > +		while (post_time_ms (base) < 2)
> > +		WATCHDOG_RESET();
> 
> Are you absolutely sure that is needed?

Maybe I should have been more explicit - note that above code with
correct indentation looks like this:

  		/* 3.2.2. strobe watchdog once */
  		WATCHDOG_RESET();
		base = post_time_ms (0);
		while (post_time_ms (base) < 2)
			WATCHDOG_RESET();

I. e. the comment "once" is wrong - you trigger the watchdog many more
times that you probably think.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Witch!  Witch!  They'll burn ya!
	-- Hag, "Tomorrow is Yesterday", stardate unknown