[U-Boot-Users] [U-boot] [PATCH 2/2] ds174x: Fix warning on return in rtc_get and rtc_set function

Jean-Christophe PLAGNIOL-VILLARD
2008-04-09T08:46:35Z

On 23:01 Tue 08 Apr , Wolfgang Denk wrote:
> In message <1207116238-7253-3-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > ds174x.c: In function 'rtc_get':
> > ds174x.c:117: warning: no return statement in function returning non-void
> > ds174x.c: In function 'rtc_set':
> > ds174x.c:146: warning: 'return' with a value, in function returning void
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >
> > diff --git a/drivers/rtc/ds174x.c b/drivers/rtc/ds174x.c
> > index 81a9cb3..eb3ca88 100644
> > --- a/drivers/rtc/ds174x.c
> > +++ b/drivers/rtc/ds174x.c
> > @@ -114,6 +114,7 @@ int rtc_get( struct rtc_time *tmp )
> > tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
> > tmp->tm_hour, tmp->tm_min, tmp->tm_sec );
> > #endif
> > + return 0;
> > }
> >
> > void rtc_set( struct rtc_time *tmp )
> > @@ -142,8 +143,6 @@ void rtc_set( struct rtc_time *tmp )
> >
> > /* unlock clock registers after read */
> > rtc_write( RTC_CONTROLA, ( reg_a & ~RTC_CA_WRITE ));
> > -
> > - return 0;
> > }
> >
> > void rtc_reset (void)
>
> I think this is actually not the right fix.
>
> To make things right, both rtc_set() and rtc_get() should return
> "int".
>
> Yes, I'm aware that this is far beyond the scope of your fixes here,
> but I wanted to at least note that.
>
> Note that this is no NAK.
>
I can add it in my task for this fix window or in the next merge windows

Best Regards,
J.