[U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

[U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

[Sascha Laue]

Hi, 

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

Change configuartion for lwmon5 board.

Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
 include/configs/lwmon5.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index ced7ba6..ff4bc80 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -434,7 +434,9 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command         */
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
+#if 0                               /* enable only for debug */
 #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
+#endif
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
 
 /*-----------------------------------------------------------------------
-- 
1.5.2.4

[U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

[Wolfgang Denk]

In message <20080403061920.271430@gmx.net> you wrote:
> Hi, 
> 
> Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5
> 
> Change configuartion for lwmon5 board.
> 
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> ---
>  include/configs/lwmon5.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
> index ced7ba6..ff4bc80 100644
> --- a/include/configs/lwmon5.h
> +++ b/include/configs/lwmon5.h
> @@ -434,7 +434,9 @@
>  #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
>  #define CONFIG_LOOPW            1       /* enable loopw command         */
>  #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
> +#if 0                               /* enable only for debug */
>  #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
> +#endif
>  #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */

Please don't add dead code. If you want to remove that line, then
please remove it. No "#if 0", please.

Viele Gr??e,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.

[U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

[Sascha Laue]

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5
Change configuartion for lwmon5 board.

Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
 include/configs/lwmon5.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index ced7ba6..cb2c4b5 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -434,7 +434,6 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command         */
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
-#define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
 
 /*-----------------------------------------------------------------------
-- 
1.5.2.4

-------- Original-Nachricht --------
> Datum: Thu, 03 Apr 2008 11:38:20 +0200
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: u-boot-users at lists.sourceforge.net
> Betreff: Re: [U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

> In message <20080403061920.271430@gmx.net> you wrote:
> > Hi, 
> > 
> > Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5
> > 
> > Change configuartion for lwmon5 board.
> > 
> > Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> > ---
> >  include/configs/lwmon5.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
> > index ced7ba6..ff4bc80 100644
> > --- a/include/configs/lwmon5.h
> > +++ b/include/configs/lwmon5.h
> > @@ -434,7 +434,9 @@
> >  #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
> >  #define CONFIG_LOOPW            1       /* enable loopw command        
> */
> >  #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands     
> */
> > +#if 0                               /* enable only for debug */
> >  #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on
> bootdelay==0 */
> > +#endif
> >  #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
> 
> Please don't add dead code. If you want to remove that line, then
> please remove it. No "#if 0", please.
> 
> Viele Gr??e,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> There are three ways to get something done:
>         (1) Do it yourself.
>         (2) Hire someone to do it for you.
>         (3) Forbid your kids to do it.

[U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

[Wolfgang Denk]

In message <20080403124311.204560@gmx.net> you wrote:
> Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5
> Change configuartion for lwmon5 board.
> 
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> ---
>  include/configs/lwmon5.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker