public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List
Date: Sat, 12 Apr 2008 15:29:15 -0400	[thread overview]
Message-ID: <200804121529.15954.vapier@gentoo.org> (raw)
In-Reply-To: <C42519C4.E8EE%gerickson@nuovations.com>

On Friday 11 April 2008, Grant Erickson wrote:
> When building against non-local, non-disk-backed file systems (e.g. NFS,
> tmpfs), the u-boot build can iterate forever, attempting to re-generate
> "include/autoconf.mk". This occurs because $(VERSION_FILE) (aka
> ${ROOT}/u-boot/build/include/version_autogenerated.h) is always regarded as
> out-of-date because it is in the .PHONY target list, even though it's a
> real file and seems to need to be only created once and only once.
>
> This patch removes $(VERSION_FILE) from the .PHONY target list and has been
> verified to work with various flavors and builds of make-3.81 against NFS,
> ext2fs, ext3fs and tmpfs file systems.

that statement is incorrect.  the version file is supposed to be checked 
everytime you run make as it depends on a whole lot of information which 
cannot be expressed in the makefile.  thus it needs to be a PHONY.

the latest git tree does the right thing: it doesnt actually replace the file 
unless it has changed which means nothing else will get regenerated unless 
the file actually changes.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080412/351356a8/attachment.pgp 

  reply	other threads:[~2008-04-12 19:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 20:36 [U-Boot-Users] [PATCH] Remove $(VERSION_FILE) from PHONY Target List Grant Erickson
2008-04-12 19:29 ` Mike Frysinger [this message]
2008-04-13  6:20   ` Grant Erickson
2008-04-13  6:43     ` Mike Frysinger
2008-05-09  8:22 ` Wolfgang Denk
2008-05-09 16:00   ` Grant Erickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804121529.15954.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox