From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Move init_sequence table into code.
Date: Mon, 14 Apr 2008 03:09:36 +0200 [thread overview]
Message-ID: <20080414010936.E130C248B9@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 28 Mar 2008 16:45:58 BST." <1206719159-11200-1-git-send-email-Joakim.Tjernlund@transmode.se>
In message <1206719159-11200-1-git-send-email-Joakim.Tjernlund@transmode.se> you wrote:
> Global variables are not ideal before relocation to RAM.
Byt they don't cause any real problem either, or am I missing
something?
I tend to reject the patch.
> -init_fnc_t *init_sequence[] = {
The original idea of having such a list of funtion pointers which
just get executed one after another was to be able to wrap this into
some "#ifndef CONFIG_INIT_SEQUENCE" and use this to allow for board-
specific init sequences by just adding a #define with the needed list
of functions to the board config files.
Even though this feature never was used so far, I still hesitate to
throw it away - at least as long as I don't see benefits for the new
solution.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never worry about theory as long as the machinery does what it's
supposed to do. - R. A. Heinlein
next prev parent reply other threads:[~2008-04-14 1:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 15:45 [U-Boot-Users] [PATCH] Move init_sequence table into code Joakim Tjernlund
2008-03-28 15:45 ` [U-Boot-Users] [PATCH] Change env_get_char from a global function ptr to a function Joakim Tjernlund
2008-03-30 18:08 ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-30 20:59 ` Wolfgang Denk
2008-03-30 21:05 ` Joakim Tjernlund
2008-03-30 22:33 ` Wolfgang Denk
2008-03-31 7:15 ` Joakim Tjernlund
2008-04-05 17:31 ` Joakim Tjernlund
2008-04-14 1:09 ` Wolfgang Denk
2008-04-14 21:01 ` Joakim Tjernlund
2008-04-18 4:14 ` Wolfgang Denk
2008-04-14 1:09 ` Wolfgang Denk [this message]
2008-04-14 21:06 ` [U-Boot-Users] [PATCH] Move init_sequence table into code Joakim Tjernlund
2008-04-15 4:35 ` Wolfgang Denk
2008-04-15 6:40 ` Joakim Tjernlund
2008-04-18 4:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414010936.E130C248B9@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox