[U-Boot-Users] [PATCH] ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol

[U-Boot-Users] [PATCH] ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol

[Bartlomiej Sieka]

Recent commit a4986459 adds reference to dcache_enable, thus breaking the
build on PPC440. This patch adds a stub for dcache_enable, similarly to
what's being done for other cache operations.

Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>
---

 cpu/ppc4xx/cache.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/cpu/ppc4xx/cache.S b/cpu/ppc4xx/cache.S
index 5124dec..ceb3ec0 100644
--- a/cpu/ppc4xx/cache.S
+++ b/cpu/ppc4xx/cache.S
@@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache)
 #ifdef CONFIG_440
 
        .globl  dcache_disable
+       .globl  dcache_enable
        .globl  icache_disable
        .globl  icache_enable
 dcache_disable:
+dcache_enable:
 icache_disable:
 icache_enable:
 	blr

[U-Boot-Users] [PATCH v2] ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol

[Bartlomiej Sieka]

Recent commit 017e9b79 adds reference to dcache_enable, thus breaking the
build on PPC440. This patch adds a stub for dcache_enable, similarly to
what's being done for other cache operations.

Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>
---
Fixed an off-by-one error in the commit id -- it should be 017e9b79
instead of a4986459.

 cpu/ppc4xx/cache.S |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/cpu/ppc4xx/cache.S b/cpu/ppc4xx/cache.S
index 5124dec..ceb3ec0 100644
--- a/cpu/ppc4xx/cache.S
+++ b/cpu/ppc4xx/cache.S
@@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache)
 #ifdef CONFIG_440
 
        .globl  dcache_disable
+       .globl  dcache_enable
        .globl  icache_disable
        .globl  icache_enable
 dcache_disable:
+dcache_enable:
 icache_disable:
 icache_enable:
 	blr

[U-Boot-Users] [PATCH v2] ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol

[Stefan Roese]

On Friday 18 April 2008, Bartlomiej Sieka wrote:
> Recent commit 017e9b79 adds reference to dcache_enable, thus breaking the
> build on PPC440. This patch adds a stub for dcache_enable, similarly to
> what's being done for other cache operations.

Finally I manage to read the mailing lists. And you fixed the problem too. :) 
Great, thanks.

BTW: Please keep me on CC on all ppc4xx (or CFI etc) related patches. This way 
I "see" the patches earlier.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol

[Wolfgang Denk]

In message <20080418095616.18864.23500.stgit@pollux.denx.de> you wrote:
> Recent commit a4986459 adds reference to dcache_enable, thus breaking the
> build on PPC440. This patch adds a stub for dcache_enable, similarly to
> what's being done for other cache operations.
> 
> Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>
> ---
> 
>  cpu/ppc4xx/cache.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu/ppc4xx/cache.S b/cpu/ppc4xx/cache.S
> index 5124dec..ceb3ec0 100644
> --- a/cpu/ppc4xx/cache.S
> +++ b/cpu/ppc4xx/cache.S
> @@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache)
>  #ifdef CONFIG_440
>  
>         .globl  dcache_disable
> +       .globl  dcache_enable
>         .globl  icache_disable
>         .globl  icache_enable
>  dcache_disable:
> +dcache_enable:
>  icache_disable:
>  icache_enable:
>  	blr

Thanks, but as mentiuoned before (in my message to Stafan as the  4xx
custodian), the whole idea of having such "stubs" (I'd rather call it
"bad and evil fakes") seems not acceptable to me.

I want to see this cleaned up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Question: How does one get fresh air into a Russian church?
Answer:   One clicks on an icon, and a window opens!