[U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2)

Wolfgang Denk
2008-04-29T13:43:18Z

In message <E1JqokH-000IQ6-00.vasiliy-leonenko-mail-ru@f128.mail.ru> you wrote:
>
> The first patch (support of long commands):

That's not exactly a good commit message.

And your signed-off-by line is missing.

And the coding style is broken. There are trailing white spaces,
and...

> #if defined(__LITTLE_ENDIAN) || defined(CFG_WRITE_SWAPPED_DATA)
> - for (i = info->portwidth; i > 0; i--)
> + for (i = sizeof(cfiword_t); i > 0; i--)
> + {

... bad brace style here and elsewhere.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on, she wants to
start living her own life." "Whose life she's _been_ living, then?"
- Terry Pratchett, _Witches Abroad_