[U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2)

Wolfgang Denk
2007-09-28T14:47:15Z

Dear Vasiliy,

in message <E1IbE2e-000EEu-00.vasiliy-leonenko-mail-ru@f97.mail.ru> you wrote:
>
> > Your patch was corrupted by your mailer which wrapped long lines. It
> > cannot be applied.
> Thank you very much for your reply. Gmail wrapped long lines. So I changed mail box. This is the second attempt.
>
> The patch was verified on different kinds of NOR using Mainstone II platform - no issues are found on u-boot (versions 1.3.0-rc1 and 1.3.0-rc2).
>
> Any comments and suggestions are welcome.

I'm a bit scared about your patch. Which tools do you use to create it?

> @@ -184,8 +186,8 @@ flash_info_t flash_info[CFG_MAX_FLASH_BA
> typedef unsigned long flash_sect_t;
>
> static void flash_add_byte (flash_info_t * info, cfiword_t * cword, uchar c);
> -static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf);
> -static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
> +static void flash_make_cmd (flash_info_t * info, ulong cmd, void *cmdbuf);
> +static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, ulong cmd);
> static void flash_unlock_seq (flash_info_t * info, flash_sect_t sect);
> static int flash_isequal (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);
> static int flash_isset (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd);

I don't see any differences here. Why is this flagged as a change?

...
> @@ -903,7 +911,7 @@ static void flash_add_byte (flash_info_t
> /*-----------------------------------------------------------------------
> * make a proper sized command based on the port and chip widths
> */
> -static void flash_make_cmd (flash_info_t * info, uchar cmd, void *cmdbuf)
> +static void flash_make_cmd (flash_info_t * info, ulong cmd, void *cmdbuf)
> {
> int i;
> uchar *cp = (uchar *) cmdbuf;

Ditto.

> @@ -913,13 +921,13 @@ static void flash_make_cmd (flash_info_t
...
>
> /*
> * Write a proper sized command to the correct address
> */
> -static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, uchar cmd)
> +static void flash_write_cmd (flash_info_t * info, flash_sect_t sect, uint offset, ulong cmd)

Ditto.

This smells somewhat fishy. Do you have an explanation what's going on
here?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
2000 pounds of chinese soup = 1 Won Ton