public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 0/2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796
Date: Tue, 22 Apr 2008 12:02:38 +0200	[thread overview]
Message-ID: <20080422100238.BDB04247AF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Tue, 22 Apr 2008 08:28:36 +0200." <20080422062836.GB22850@game.jcrosoft.org>

In message <20080422062836.GB22850@game.jcrosoft.org> you wrote:
>
> > > Move non-inlied functions into specific drivers file
> > > Set get_prom as weak
> > > 
> > > Coding Style Cleanup
> > 
> > Please split in two (3?) separate patches. Thanks.
> 
> We could separate the Coding style in an other patch
> but if possible i'll let it in the same patch.

Please split it up, because otherwise the changes are really difficult
to see.

> Seperate the moving of non-inlined functions and the setting of get_prom
> as weak is ine block to fix the regression

OK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's a small world, but I wouldn't want to paint it.

  reply	other threads:[~2008-04-22 10:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 17:22 [U-Boot-Users] [PATCH 0/2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796 Jean-Christophe PLAGNIOL-VILLARD
2008-04-21 17:22 ` [U-Boot-Users] [PATCH 1/2] qemu-mips: add CFI support and coding style cleanup Jean-Christophe PLAGNIOL-VILLARD
2008-04-21 17:22   ` [U-Boot-Users] [PATCH 2/2] qemu-mips: add full functionnalty and support of CONFIG_SMALLEST Jean-Christophe PLAGNIOL-VILLARD
2008-04-21 17:48     ` [U-Boot-Users] [PATCH 2/2 V2] " Jean-Christophe PLAGNIOL-VILLARD
2008-04-21 19:26       ` Wolfgang Denk
2008-04-22  6:26         ` Jean-Christophe PLAGNIOL-VILLARD
2008-04-22 10:01           ` Wolfgang Denk
2008-04-22  7:26         ` Shinya Kuribayashi
2008-04-22  7:38           ` Shinya Kuribayashi
2008-04-22 15:10   ` [U-Boot-Users] [PATCH 1/2][MIPS] qemu-mips: Cleanup whiespaces, tab indentations, etc Shinya Kuribayashi
2008-04-22 15:32     ` Wolfgang Denk
2008-04-22 15:35       ` Shinya Kuribayashi
2008-04-22 20:50       ` Jean-Christophe PLAGNIOL-VILLARD
2008-04-23  2:02         ` Shinya Kuribayashi
2008-04-25  7:16           ` Wolfgang Denk
2008-04-22 15:11   ` [U-Boot-Users] [PATCH 2/2][MIPS] qemu-mips.h: Add CFI support Shinya Kuribayashi
2008-04-25  7:16     ` Wolfgang Denk
2008-04-21 19:24 ` [U-Boot-Users] [PATCH 0/2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796 Wolfgang Denk
2008-04-22  6:28   ` Jean-Christophe PLAGNIOL-VILLARD
2008-04-22 10:02     ` Wolfgang Denk [this message]
     [not found]       ` <1209015794-9805-1-git-send-email-plagnioj@jcrosoft.com>
2008-04-24  5:43         ` [U-Boot-Users] [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2008-04-24  5:57           ` [U-Boot-Users] [PATCH 0/1 V2] NE2000: coding style cleanup Jean-Christophe PLAGNIOL-VILLARD
2008-04-24  5:57             ` [U-Boot-Users] [PATCH 1/1 V2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796 Jean-Christophe PLAGNIOL-VILLARD
2008-04-25  7:16             ` [U-Boot-Users] [PATCH 0/1 V2] NE2000: coding style cleanup Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080422100238.BDB04247AF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox