From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 22 Apr 2008 12:02:38 +0200 Subject: [U-Boot-Users] [PATCH 0/2] NE2000: Fix regresssion introduced by e710185aae90 on non AX88796 In-Reply-To: Your message of "Tue, 22 Apr 2008 08:28:36 +0200." <20080422062836.GB22850@game.jcrosoft.org> Message-ID: <20080422100238.BDB04247AF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <20080422062836.GB22850@game.jcrosoft.org> you wrote: > > > > Move non-inlied functions into specific drivers file > > > Set get_prom as weak > > > > > > Coding Style Cleanup > > > > Please split in two (3?) separate patches. Thanks. > > We could separate the Coding style in an other patch > but if possible i'll let it in the same patch. Please split it up, because otherwise the changes are really difficult to see. > Seperate the moving of non-inlined functions and the setting of get_prom > as weak is ine block to fix the regression OK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It's a small world, but I wouldn't want to paint it.