public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them
@ 2008-04-23 21:58 Kumar Gala
  2008-04-23 22:35 ` Andy Fleming
  2008-04-24 12:22 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Kumar Gala @ 2008-04-23 21:58 UTC (permalink / raw)
  To: u-boot

pme_msg_det exists only on PCIe controllers only set it if we are a "bridge".

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

A fix for 1.3.3.

 drivers/pci/fsl_pci_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/fsl_pci_init.c b/drivers/pci/fsl_pci_init.c
index 68e45e1..7dc33be 100644
--- a/drivers/pci/fsl_pci_init.c
+++ b/drivers/pci/fsl_pci_init.c
@@ -182,7 +182,8 @@ fsl_pci_init(struct pci_controller *hose)

 	/* Clear all error indications */

-	pci->pme_msg_det = 0xffffffff;
+	if (bridge)
+		pci->pme_msg_det = 0xffffffff;
 	pci->pedr = 0xffffffff;

 	pci_hose_read_config_word (hose, dev, PCI_DSR, &temp16);
-- 
1.5.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them
  2008-04-23 21:58 [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them Kumar Gala
@ 2008-04-23 22:35 ` Andy Fleming
  2008-04-24 12:22 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Fleming @ 2008-04-23 22:35 UTC (permalink / raw)
  To: u-boot

On Wed, Apr 23, 2008 at 4:58 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
> pme_msg_det exists only on PCIe controllers only set it if we are a "bridge".
>
>  Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Acked-by: Andy Fleming <afleming@freescale.com>

Though it'd be nice if you at least put a semicolon between
"controllers" and "only".  ;)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them
  2008-04-23 21:58 [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them Kumar Gala
  2008-04-23 22:35 ` Andy Fleming
@ 2008-04-24 12:22 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2008-04-24 12:22 UTC (permalink / raw)
  To: u-boot

In message <Pine.LNX.4.64.0804231657230.13544@blarg.am.freescale.net> you wrote:
> pme_msg_det exists only on PCIe controllers only set it if we are a "bridge".
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> 
> A fix for 1.3.3.
> 
>  drivers/pci/fsl_pci_init.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're dead, Jim.
	-- McCoy, "Amok Time", stardate 3372.7

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-04-24 12:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 21:58 [U-Boot-Users] [PATCH] fsl_pci: Only modify registers if we have them Kumar Gala
2008-04-23 22:35 ` Andy Fleming
2008-04-24 12:22 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox