public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Support for LinkStation / KuroBox HD and HG PPC models
Date: Mon, 28 Apr 2008 12:22:41 +0200	[thread overview]
Message-ID: <20080428102241.A83D0247AF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Mon, 31 Mar 2008 01:32:15 +0200." <Pine.LNX.4.64.0803310112130.6825@axis700.grange>

In message <Pine.LNX.4.64.0803310112130.6825@axis700.grange> you wrote:
> This patch is based on the port by Mihai Georgian (see linkstation.c for 
> Copyright information) and implements support for LinkStation / KuroBox HD 
> and HG PPC models from Buffalo Technology, whereby HD is deactivated at 
> the moment, pending network driver fixing.

The code throws a lot of compiler warnings:

===== LOG/linkstation_HGLAN =====
hwctl.c: In function 'miconCntl_SendUart':
hwctl.c:30: warning: pointer targets in passing argument 1 of 'out_8' differ in signedness
rtl8169.c: In function 'rtl_recv':
rtl8169.c:438: warning: passing argument 1 of '__fswab32' makes integer from pointer without a cast
rtl8169.c: In function 'rtl_send':
rtl8169.c:484: warning: passing argument 1 of '__fswab32' makes integer from pointer without a cast
rtl8169.c: In function 'rtl8169_hw_start':
rtl8169.c:582: warning: passing argument 2 of 'out_le32' makes integer from pointer without a cast
rtl8169.c:583: warning: passing argument 2 of 'out_le32' makes integer from pointer without a cast
rtl8169.c: In function 'rtl8169_init_ring':
rtl8169.c:628: warning: passing argument 1 of '__fswab32' makes integer from pointer without a cast
cmd_ide.c: In function 'ide_read':
cmd_ide.c:1267: warning: integer constant is too large for 'long' type
cmd_ide.c:1321: warning: right shift count >= width of type
cmd_ide.c:1322: warning: right shift count >= width of type
cmd_ide.c: In function 'ide_write':
cmd_ide.c:1386: warning: integer constant is too large for 'long' type
cmd_ide.c:1411: warning: right shift count >= width of type
cmd_ide.c:1412: warning: right shift count >= width of type


Also, ther eis no entry for this board in the MAINTAINERS file.


Please fix. Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning there was nothing.
And the Lord said "Let There Be Light!"
And still there was nothing, but at least now you could see it.

  parent reply	other threads:[~2008-04-28 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-30 23:32 [U-Boot-Users] [PATCH 2/2] Support for LinkStation / KuroBox HD and HG PPC models Guennadi Liakhovetski
2008-04-14  6:33 ` Wolfgang Denk
2008-04-28 10:22 ` Wolfgang Denk [this message]
2008-04-28 12:35   ` [U-Boot-Users] [PATCH] LinkStation: fix compiler warning, add a maintainer Guennadi Liakhovetski
2008-04-28 18:43     ` Wolfgang Denk
2008-04-28 12:36   ` [U-Boot-Users] [PATCH] IDE: fix compiler warnings Guennadi Liakhovetski
2008-04-28 18:43     ` Wolfgang Denk
2008-04-28 12:37   ` [U-Boot-Users] [PATCH] rtl8169: " Guennadi Liakhovetski
2008-04-28 18:43     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428102241.A83D0247AF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox