From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 28 Apr 2008 23:22:38 +0200
Subject: [U-Boot-Users] [PATCH v2] PPC405EX(r) ECC and SDRAM
	Initialization Clean-ups
In-Reply-To: Your message of "Mon, 28 Apr 2008 09:53:56 PDT."
	<1209401636-9846-2-git-send-email-gerickson@nuovations.com>
Message-ID: <20080428212239.09304247B4@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

In message <1209401636-9846-2-git-send-email-gerickson@nuovations.com> you wrote:
> ---
>  board/amcc/kilauea/init.S |   53 +++++++++++--
>  board/amcc/makalu/init.S  |   53 +++++++++++--
>  cpu/ppc4xx/Makefile       |    1 +
>  cpu/ppc4xx/ecc.S          |  195 +++++++++++++++++++++++++++++++++++++++++++++
>  cpu/ppc4xx/sdram.c        |   47 +----------
>  5 files changed, 292 insertions(+), 57 deletions(-)

There are a couple of problems with your posting:

- there is no signed-off-by line
- there is no explanation what you're actually trying to
  add or to fix.
- there are coding style violations: C++ comments, trailing white
  space, ...
- the code contains way too many empty lines / vertical white space.
- even in pseudo code, the Coding style requirements apply; i. e.
  instead of
  	+       /*
	+        *   if (start >= end) {
	+        *       return;
	+        *   }   
	+        */
  please write
  	+       /*
	+        *   if (start >= end)
	+        *       return;
	+        */
  etc.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Your own mileage may vary.