From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 29 Apr 2008 07:54:33 +0200
Subject: [U-Boot-Users] PPC440EPx/sequoia TLB question...
In-Reply-To: <48128B6B.8090909@verizon.net>
References: <480EA8E1.4060207@verizon.net> <200804231442.29687.sr@denx.de>
	<48128B6B.8090909@verizon.net>
Message-ID: <200804290754.33134.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 26 April 2008, Dave Littell wrote:
> Here goes (again):
>
> Patch for AMCC Sequoia to remove the TLB Guarded attribute for SDRAM,
> and add the Guarded attribute for Internal Registers & OCM.

I still have a few issues with this patch:

- Signed-off-by line missing
- Please use a descriptive subject for this patch, something like:
  "[PATCH] ppc4xx: Fix guarded bit in some Sequoia TLB entries"
- Comments that should not be part of the commit text should go
  below the "---" line in the email. Please take a look at other
  patches sent to the list on how exactly this should be done.
- And best would be to create two separate TLB entries, one for
  internal SRAM (OCM) with G cleared and one for internal registers
  with G set

I strongly suggest to work with the git tools to create and send patches. This 
makes life a lot easier for all of us.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================