public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2)
Date: Tue, 29 Apr 2008 15:02:55 +0200	[thread overview]
Message-ID: <20080429130255.GA6355@game.jcrosoft.org> (raw)
In-Reply-To: <E1Jqoj8-000FYw-00.vasiliy-leonenko-mail-ru@f185.mail.ru>

On 16:14 Tue 29 Apr     , Vasiliy Leoenenko wrote:
> 
> Hi Stefan
> 
> > Unfortunately this breaks CFI support for "normal" AMD/Spansion FLASH equipped
> > boards. On Sequoia with Spansion GL512 I get this after applying your patch:
> > 
> > Please fix this and resubmit. Best would be if you could test it on a board
> > with Spansion CFI FLASH's too.
> 
> I investigated the reproted issue and I think I've corrected it. The issue caused by my incorect conversion of cmd value in flash_make_cmd function.
> So we improved the procedure of conversion. I think it will be better to sent two patches:
> The first patch adds support of long commands and fixes conversion issues.
> The second patch adds M18 family command set support. 
> 
> Patches were tested on Mainstone II board and two flashes:
> M18 portwidth=16 chipwidth=16
> P30 portwidth=32 chipwidth=16
> Also I tested in simulation the conversion algorithms to make sure that it works fine. 
> Unforunately I have no abiliy to test my patch on different borads and width Spansion CFI flash.

You could test it on qemu_mips which use an amd cfi flash or with few
modif in qemu an intel falsh

Best Regards,
J.

  reply	other threads:[~2008-04-29 13:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 11:29 [U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2) Vasiliy Leoenenko
2007-09-28 14:47 ` Wolfgang Denk
2007-09-28 15:47   ` Alexey Korolev
2007-09-28 16:40     ` Wolfgang Denk
2008-04-21  7:02 ` Stefan Roese
2008-04-23  9:42   ` Vasiliy Leoenenko
2008-04-25  6:35     ` Stefan Roese
2008-04-29 12:14       ` Vasiliy Leoenenko
2008-04-29 13:02         ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-04-29 12:15       ` Vasiliy Leoenenko
2008-04-29 12:43         ` Stefan Roese
2008-04-29 13:43         ` Wolfgang Denk
2008-04-29 14:39           ` Vasiliy Leoenenko
2008-04-29 14:40           ` Vasiliy Leoenenko
2008-04-29 15:03             ` Anatolij Gustschin
2008-05-07 17:23               ` Vasiliy Leoenenko
2008-05-07 17:24               ` Vasiliy Leoenenko
2008-06-03 19:07                 ` Stefan Roese
2008-05-07 17:25               ` Vasiliy Leoenenko
2008-06-03 19:07                 ` Stefan Roese
2008-05-07 18:05               ` Vasiliy Leoenenko
2008-05-12  9:36                 ` Vasiliy Leonenko
2008-05-13  5:42                   ` Stefan Roese
2008-04-29 14:40           ` Vasiliy Leoenenko
2008-04-29 12:16       ` Vasiliy Leoenenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429130255.GA6355@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox