From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Tue, 29 Apr 2008 15:02:55 +0200 Subject: [U-Boot-Users] [PATCH] M18 flash (Sibley) support (attempt 2) In-Reply-To: References: <200804250835.29033.sr@denx.de> Message-ID: <20080429130255.GA6355@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:14 Tue 29 Apr , Vasiliy Leoenenko wrote: > > Hi Stefan > > > Unfortunately this breaks CFI support for "normal" AMD/Spansion FLASH equipped > > boards. On Sequoia with Spansion GL512 I get this after applying your patch: > > > > Please fix this and resubmit. Best would be if you could test it on a board > > with Spansion CFI FLASH's too. > > I investigated the reproted issue and I think I've corrected it. The issue caused by my incorect conversion of cmd value in flash_make_cmd function. > So we improved the procedure of conversion. I think it will be better to sent two patches: > The first patch adds support of long commands and fixes conversion issues. > The second patch adds M18 family command set support. > > Patches were tested on Mainstone II board and two flashes: > M18 portwidth=16 chipwidth=16 > P30 portwidth=32 chipwidth=16 > Also I tested in simulation the conversion algorithms to make sure that it works fine. > Unforunately I have no abiliy to test my patch on different borads and width Spansion CFI flash. You could test it on qemu_mips which use an amd cfi flash or with few modif in qemu an intel falsh Best Regards, J.