[U-Boot-Users] [PATCH] ppc4xx: Fix Katmai CFG_MONITOR_LEN

[U-Boot-Users] [PATCH] ppc4xx: Fix Katmai CFG_MONITOR_LEN

[Stefan Roese]

Signed-off-by: Stefan Roese <sr@denx.de>
---
 include/configs/katmai.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/katmai.h b/include/configs/katmai.h
index 122b700..aad28fb 100644
--- a/include/configs/katmai.h
+++ b/include/configs/katmai.h
@@ -48,7 +48,7 @@
  * Base addresses -- Note these are effective addresses where the
  * actual resources get mapped (not physical addresses)
  *----------------------------------------------------------------------*/
-#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
+#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */
 #define CFG_MALLOC_LEN		(512 * 1024)	/* Reserve 512 kB for malloc */
 
 #define CFG_SDRAM_BASE		0x00000000	/* _must_ be 0		*/
-- 
1.5.5.1

[U-Boot-Users] [PATCH] ppc4xx: Fix Katmai CFG_MONITOR_LEN

[Wolfgang Denk]

In message <1209471160-4453-1-git-send-email-sr@denx.de> you wrote:
> Signed-off-by: Stefan Roese <sr@denx.de>
...
> -#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
> +#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */

Hm... maybe we should become defensive and use

#define CFG_MONITOR_LEN (0xFFFFFFFF - CFG_MONITOR_BASE + 1)

instead?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's certainly  convenient  the  way  the  crime  (or  condition)  of
stupidity   carries   with   it  its  own  punishment,  automatically
admisistered without remorse, pity, or prejudice. :-)
         -- Tom Christiansen in <559seq$ag1$1@csnews.cs.colorado.edu>

[U-Boot-Users] [PATCH] ppc4xx: Fix Katmai CFG_MONITOR_LEN

[Stefan Roese]

On Tuesday 29 April 2008, Wolfgang Denk wrote:
> In message <1209471160-4453-1-git-send-email-sr@denx.de> you wrote:
> > Signed-off-by: Stefan Roese <sr@denx.de>
>
> ...
>
> > -#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
> > +#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */
>
> Hm... maybe we should become defensive and use
>
> #define CFG_MONITOR_LEN (0xFFFFFFFF - CFG_MONITOR_BASE + 1)
>
> instead?

Yep, even better. I'll make the necessary changes.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================