public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-04-30 13:23 Sascha Laue
  2008-04-30 20:29 ` Wolfgang Denk
  0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-04-30 13:23 UTC (permalink / raw)
  To: u-boot

Hello Wolfgang,

i found another problem with the sysmon POST.
We have to add an offset to the voltage thresholds.

best regards,
Sascha Laue

From: Sascha Laue <sascha.laue@liebherr.com>
Date: Wed, 30 Apr 2008 13:32:17 +0200
Subject: [PATCH] fix an offset error in lwmon5 sysmon0 post.

---
 post/board/lwmon5/sysmon.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
index 23cb709..e9c9624 100644
--- a/post/board/lwmon5/sysmon.c
+++ b/post/board/lwmon5/sysmon.c
@@ -133,16 +133,16 @@ static sysmon_table_t sysmon_table[] =
        {
        "+ 5 V", "V", &sysmon_dspic, NULL, NULL,
        100, 1000, -0x8000, 0x7FFF, 0xFFFF,
-       VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
-       VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+       0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0,
+       0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0,
        REG_VOLTAGE_5V,
        },

        {
        "+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
        100, 1000, -0x8000, 0x7FFF, 0xFFFF,
-       VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
-       VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
+       0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+       0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
        REG_VOLTAGE_5V_STANDBY,
        },
 };
--
1.5.2.4


-------- Original-Nachricht --------
> Datum: Mon, 28 Apr 2008 22:41:39 +0200
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: marcel.brasch at liebherr.com, u-boot-users at lists.sourceforge.net, mk at denx.de
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification

> In message <20080401075646.145810@gmx.net> you wrote:
> >
> > sorry but it's the first time for me.
> > let's try again.
> >
> > we modified the specification for the lwmon5 board dspic POST.
> > Additionally I have add defines for the temperature- and voltagevalues.
> >
> > Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> > ---
> >  post/board/lwmon5/sysmon.c |   39
> ++++++++++++++++++++++++++++++---------
> >  1 files changed, 30 insertions(+), 9 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Committee, n.:  A group of men who individually can do nothing but as
> a group decide that nothing can be done.                 - Fred Allen

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-04-30 13:16 Sascha Laue
  2008-04-30 19:56 ` Wolfgang Denk
  0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-04-30 13:16 UTC (permalink / raw)
  To: u-boot

Hello Wolfgang,

I've found this merge-merge-error.

best regards
Sascha Laue

From: Sascha Laue <sascha.laue@liebherr.com>
Date: Wed, 30 Apr 2008 12:27:21 +0200
Subject: [PATCH] fix manual merge error in lwmon5 posttest.

Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
 post/board/lwmon5/sysmon.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
index 793f670..23cb709 100644
--- a/post/board/lwmon5/sysmon.c
+++ b/post/board/lwmon5/sysmon.c
@@ -132,7 +132,7 @@ static sysmon_table_t sysmon_table[] =

        {
        "+ 5 V", "V", &sysmon_dspic, NULL, NULL,
-       100, 1000, 0, 0xFFFF, 0xFFFF,
+       100, 1000, -0x8000, 0x7FFF, 0xFFFF,
        VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
        VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
        REG_VOLTAGE_5V,
@@ -140,7 +140,7 @@ static sysmon_table_t sysmon_table[] =

        {
        "+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
-       100, 1000, 0, 0xFFFF, 0xFFFF,
+       100, 1000, -0x8000, 0x7FFF, 0xFFFF,
        VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
        VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
        REG_VOLTAGE_5V_STANDBY,
--
1.5.2.4


-------- Original-Nachricht --------
> Datum: Mon, 28 Apr 2008 22:41:39 +0200
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: marcel.brasch at liebherr.com, u-boot-users at lists.sourceforge.net, mk at denx.de
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification

> In message <20080401075646.145810@gmx.net> you wrote:
> >
> > sorry but it's the first time for me.
> > let's try again.
> >
> > we modified the specification for the lwmon5 board dspic POST.
> > Additionally I have add defines for the temperature- and voltagevalues.
> >
> > Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> > ---
> >  post/board/lwmon5/sysmon.c |   39
> ++++++++++++++++++++++++++++++---------
> >  1 files changed, 30 insertions(+), 9 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Committee, n.:  A group of men who individually can do nothing but as
> a group decide that nothing can be done.                 - Fred Allen

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-03-20 11:54 Sascha Laue
  2008-03-20 12:00 ` Markus Klotzbücher
  0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-03-20 11:54 UTC (permalink / raw)
  To: u-boot

Hi all,

we modified the specification for the lwmon5 board dspic POST. 
Additionally I have add defines for the temperature- and voltagevalues.

Signed-of-by: Sascha Laue <sascha.laue@liebherr.com>
Signed-of-by: Marcel Brasch <marcel.brasch@liebherr.com>

@@ -34,9 +34,10 @@
  * The test passes when all the following voltages and temperatures
  * are within allowed ranges:
  *
- * Temperature                -40 .. +85 C
- * +5V                      +4.75 .. +5.25 V
- * +5V standby              +4.75 .. +5.25 V
+ * Temperature                -40 .. +90 ?C
+ * Tempreature_Display		  -35 .. +85 ?C
+ * +5V                      +4.50 .. +5.50 V
+ * +5V standby              +3.50 .. +5.50 V
  *
  * LCD backlight is not enabled if temperature values are not within
  * allowed ranges (-30 .. + 80). The brightness of backlite can be
@@ -62,6 +63,21 @@
 
 #define	RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) + gd->reloc_off)
 
+#define REG_TEMPERATURE                   0x12BC
+#define REG_VOLTAGE_5V                    0x12CA
+#define REG_VOLTAGE_5V_STANDBY            0x12C6
+
+#define TEMPERATURE_MIN                     (-40)  /* ?C */
+#define TEMPERATURE_MAX                     (+90)  /* ?C */
+#define TEMPERATURE_DISPLAY_MIN             (-35)  /* ?C */
+#define TEMPERATURE_DISPLAY_MAX             (+85)  /* ?C */  
+
+#define VOLTAGE_5V_MIN                    (+4500)  /* mV */
+#define VOLTAGE_5V_MAX                    (+5500)  /* mV */
+
+#define VOLTAGE_5V_STANDBY_MIN            (+3500)  /* mV */
+#define VOLTAGE_5V_STANDBY_MAX            (+5500)  /* mV */
+
 typedef struct sysmon_s sysmon_t;
 typedef struct sysmon_table_s sysmon_table_t;
 
@@ -110,16 +126,22 @@
 static sysmon_table_t sysmon_table[] =
 {
     {"Temperature", " C", &sysmon_dspic, NULL, sysmon_backlight_disable,
-     1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
-                                  0x8000-30, 0x8000+80, 0, 0x12BC},
+     1, 1, -0x8000, 0x7FFF, 0xFFFF, 
+	 0x8000 + TEMPERATURE_MIN , 0x8000 + TEMPERATURE_MAX , 0,
+     0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0, 
+	 REG_TEMPERATURE},
 
     {"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
-     100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
-                                         0x8000+4750, 0x8000+5250, 0, 0x12CA},
+     100, 1000, -0x8000, 0x7FFF, 0xFFFF, 
+	 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
+	 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0, 
+	 REG_VOLTAGE_5V},
 
     {"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
-     100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
-                                         0x8000+4750, 0x8000+5250, 0, 0x12C6},
+     100, 1000, -0x8000, 0x7FFF, 0xFFFF, 
+	 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+     0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0, 
+	 REG_VOLTAGE_5V_STANDBY},
 };
 static int sysmon_table_size = sizeof(sysmon_table) / sizeof(sysmon_table[0]);

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2008-04-30 20:29 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-30 13:23 [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification Sascha Laue
2008-04-30 20:29 ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2008-04-30 13:16 Sascha Laue
2008-04-30 19:56 ` Wolfgang Denk
2008-03-20 11:54 Sascha Laue
2008-03-20 12:00 ` Markus Klotzbücher
2008-03-20 12:05   ` Sascha Laue
2008-03-25 23:18     ` Wolfgang Denk
2008-04-01  7:56       ` Sascha Laue
2008-04-01  8:10         ` Sascha Laue
2008-04-28 20:41         ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox