public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ColdFire: Get information from the correct GCC
Date: Sat, 03 May 2008 23:11:26 +0200	[thread overview]
Message-ID: <20080503211126.35DFD248A6@gemini.denx.de> (raw)
In-Reply-To: Your message of "Thu, 01 May 2008 12:42:47 +0900." <48193C37.6030106@ruby.dti.ne.jp>

In message <48193C37.6030106@ruby.dti.ne.jp> you wrote:
>
> >  PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
> > -ifeq ($(findstring 4.2,$(shell $(CC) --version)),4.2)
> > +ifeq ($(findstring 4.2,$(shell $(CROSS_COMPILE)gcc --version)),4.2)
> >  PLATFORM_CPPFLAGS += -mcpu=5208 -fPIC
> >  else
> >  PLATFORM_CPPFLAGS += -m5307 -fPIC
> 
> Let me make sure the intention of this change. With or without this
> change, we can always evaluate $(CROSS_COMPILE)gcc --version, right?
> Or am I missing something?
> 
> There are several $(CC)/$(AR)/$(AS)/$(CPP) users in cpu/*/Makefile &
> cpu/*/config.mk. I'm wondering whether we need to fix all these usages
> or not.

The thing is, that all the $(CC)/$(AR)/$(AS)/$(CPP) definitions are
fine as when used during the build process; but we have a bug when
using them in the initial steps while generating the "make" parameters
and variable settings - the bug is in config.mk which includes
cpu/*/config.mk *before* $(CC)/$(AR)/$(AS)/$(CPP) get set.

I will post a patch for this; it replaces this commit:

	commit b7166e05a513c0806b63b9dfb6f1d77645cede2a
	Author: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
	Date:   Wed Apr 30 12:10:23 2008 -0500

	    ColdFire: Get information from the correct GCC

which I'm going to revert when the patch gets applied.

These changes have already been applied to the u-boot-testing
repository, see
http://git.denx.de/?p=u-boot/u-boot-testing.git;a=summary

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That was the thing about deserts. They had their  own  gravity.  They
sucked you into the centre.           - Terry Pratchett, _Small Gods_

      parent reply	other threads:[~2008-05-03 21:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 17:10 [U-Boot-Users] [PATCH] ColdFire: Get information from the correct GCC Tsi-Chung Liew
2008-04-30 20:36 ` Wolfgang Denk
2008-05-01  3:42 ` Shinya Kuribayashi
2008-05-01 21:34   ` Liew Tsi Chung
2008-05-01 22:05     ` Wolfgang Denk
2008-05-02 22:03       ` Liew Tsi Chung
2008-05-02 22:57         ` Wolfgang Denk
2008-05-03  3:25         ` Shinya Kuribayashi
2008-05-04  5:37           ` Liew Tsi Chung
2008-05-04  5:49             ` Shinya Kuribayashi
2008-05-04  8:37               ` Liew Tsi Chung
2008-05-04  9:56                 ` Shinya Kuribayashi
2008-05-04 16:34                   ` Kurt Mahan
2008-05-04 18:44                     ` Wolfgang Denk
2008-05-06  9:32                     ` Shinya Kuribayashi
2008-05-05 14:14                   ` Liew Tsi Chung
2008-05-05 22:02                     ` Wolfgang Denk
2008-05-06  6:41                       ` Liew Tsi Chung
2008-05-05 15:43                   ` Liew Tsi Chung
2008-05-04 15:40                 ` Wolfgang Denk
2008-05-03 21:11   ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080503211126.35DFD248A6@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox