public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge
Date: Mon, 5 May 2008 20:41:59 +0200	[thread overview]
Message-ID: <200805052041.59814.sr@denx.de> (raw)
In-Reply-To: <481F28FC.3040103@acm.org>

On Monday 05 May 2008, Larry Johnson wrote:
> >> Yes, I totally agree. Patches should *not* change the default behavior.
> >> We should change it as you suggested. Sorry, I must have missed this.
> >>
> >> Nobuhiro, could you please send a new patch to fix this problem?
> >
> > Thank you for your check.
> > It has troubled you with my patch.
> >
> > I rewirte new patch . Could you please check this patch and confirming
> > the work?
> >
> > Best regards,
> >  Nobuhiro
>
> Hi Nobuhiro, Stefan, and everyone,
>
> Sorry for the delay in getting back to you.  My mail reader thinks your
> patch is part of your signature, so I missed it the first time around.
>
> I did a quick check using the Sequoia board, and it looks like the patch
> isn't working there.  U-Boot is reporting the class of the bridge as
> "0680", which I assume is why the patch doesn't skip it.

Yes, I just gave the new patch a try and noticed (still) a problem on Sequoia. 
The PCI host bridge (PPC) is listed upon bootup which was not the case with 
the U-Boot version prior to the first patch.

> Nobuhiro and Stefan, do you think we can get a working fix for this into
> 1.3.3 (even if it is not the final fix)?

I definitely hope so. Even though I will probably not find the time to submit 
a patch to really fix this problem till the scheduled release date. But I 
will gladly test a patch. :)

> If not, we should patch 
> Sequoia and Korat to add CONFIG_PCI_SKIP_HOST_BRIDGE so they won't be
> broken in that release.

Or perhaps we should revert the first patch and give it another try in the 
next merge-window when/if a new patch is available.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-05-05 18:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 11:20 [U-Boot-Users] PCI stopped working on MPC8343 Andre Schwarz
2008-04-18 14:17 ` Larry Johnson
2008-04-18 14:27   ` André Schwarz
2008-04-18 16:51     ` Larry Johnson
2008-04-18 14:57   ` Stefan Roese
2008-04-28  8:00     ` [U-Boot-Users] [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge (Re: PCI stopped working on MPC8343) Nobuhiro Iwamatsu
2008-05-05 15:34       ` [U-Boot-Users] [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge Larry Johnson
2008-05-05 18:41         ` Stefan Roese [this message]
2008-05-07 16:31           ` Anton Vorontsov
2008-05-09  2:01             ` Larry Johnson
2008-05-11 23:13             ` Wolfgang Denk
2008-05-12 13:43         ` Nobuhiro Iwamatsu
2008-05-12 18:32           ` Wolfgang Denk
2008-06-17  4:59             ` Nobuhiro Iwamatsu
2008-06-17  6:39               ` [U-Boot-Users] [PATCH][RFC] pci: Add check PCI bridge class (Re: [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge) Nobuhiro Iwamatsu
2008-07-07 13:58                 ` Stefan Roese
2008-07-08  6:51                   ` Nobuhiro Iwamatsu
2008-07-08  9:27                     ` Stefan Roese
2008-07-05 22:32               ` [U-Boot-Users] [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805052041.59814.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox