From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 5 May 2008 20:41:59 +0200
Subject: [U-Boot-Users] [PATCH][RFC] pci: Remove
	CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge
In-Reply-To: <481F28FC.3040103@acm.org>
References: <480883E6.5000304@matrix-vision.de>
	<20080428170042.386ac2d6.iwamatsu@nigauri.org>
	<481F28FC.3040103@acm.org>
Message-ID: <200805052041.59814.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 05 May 2008, Larry Johnson wrote:
> >> Yes, I totally agree. Patches should *not* change the default behavior.
> >> We should change it as you suggested. Sorry, I must have missed this.
> >>
> >> Nobuhiro, could you please send a new patch to fix this problem?
> >
> > Thank you for your check.
> > It has troubled you with my patch.
> >
> > I rewirte new patch . Could you please check this patch and confirming
> > the work?
> >
> > Best regards,
> >  Nobuhiro
>
> Hi Nobuhiro, Stefan, and everyone,
>
> Sorry for the delay in getting back to you.  My mail reader thinks your
> patch is part of your signature, so I missed it the first time around.
>
> I did a quick check using the Sequoia board, and it looks like the patch
> isn't working there.  U-Boot is reporting the class of the bridge as
> "0680", which I assume is why the patch doesn't skip it.

Yes, I just gave the new patch a try and noticed (still) a problem on Sequoia. 
The PCI host bridge (PPC) is listed upon bootup which was not the case with 
the U-Boot version prior to the first patch.

> Nobuhiro and Stefan, do you think we can get a working fix for this into
> 1.3.3 (even if it is not the final fix)?

I definitely hope so. Even though I will probably not find the time to submit 
a patch to really fix this problem till the scheduled release date. But I 
will gladly test a patch. :)

> If not, we should patch 
> Sequoia and Korat to add CONFIG_PCI_SKIP_HOST_BRIDGE so they won't be
> broken in that release.

Or perhaps we should revert the first patch and give it another try in the 
next merge-window when/if a new patch is available.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================