public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] syscon3: changes to support FDT
Date: Fri, 9 May 2008 14:38:56 +0200	[thread overview]
Message-ID: <200805091438.56226.sr@denx.de> (raw)
In-Reply-To: <1210322531-11484-1-git-send-email-wd@denx.de>

On Friday 09 May 2008, Wolfgang Denk wrote:
> From: Sergei Poselenov <sposelenov@emcraft.com>
>
> Signed-off-by: Sergei Poselenov <sposelenov@emcraft.com>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  board/syscon3/syscon3.c   |   25 +++++++++++++++++++
>  include/configs/syscon3.h |   58
> +++++++++++++++++++------------------------- 2 files changed, 50
> insertions(+), 33 deletions(-)

I can't find this board support. And also no patches for it.

Please find some further comments below.

> diff --git a/board/syscon3/syscon3.c b/board/syscon3/syscon3.c
> index ea33f82..b814bae 100644
> --- a/board/syscon3/syscon3.c
> +++ b/board/syscon3/syscon3.c
> @@ -33,6 +33,8 @@
>  #include <asm/immap_85xx.h>
>  #include <ioports.h>
>  #include <flash.h>
> +#include <libfdt.h>
> +#include <fdt_support.h>
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> @@ -184,3 +186,26 @@ int board_early_init_r (void)
>  	return (0);
>  }
>  #endif /* CONFIG_BOARD_EARLY_INIT_R */
> +
> +#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
> +void
> +ft_board_setup(void *blob, bd_t *bd)
> +{
> +	u32 val[4];
> +	int rc;
> +
> +	ft_cpu_setup(blob, bd);
> +
> +	/* Fixup NOR mapping */
> +	val[0] = 0;				/* chip select number */
> +	val[1] = 0;				/* always 0 */
> +	val[2] = gd->bd->bi_flashstart;
> +	val[3] = gd->bd->bi_flashsize;
> +
> +	rc = fdt_find_and_setprop(blob, "/localbus", "ranges",
> +				  val, sizeof(val), 1);
> +	if (rc)
> +		printf("Unable to update property NOR mapping, err=%s\n",
> +		       fdt_strerror(rc));
> +}
> +#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */

This is not needed anymore. With my latest patch (available in the 
u-boot-ppc4xx repository, master branch for pulling):

[PATCH 2/3] ppc4xx: Add weak default  ft_board_setup() routine

this board specific code is not needed in this case, since it is an exact copy 
of the weak default routine. Please remove it in the next version of this 
patch.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-05-09 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09  8:42 [U-Boot-Users] [PATCH] syscon3: changes to support FDT Wolfgang Denk
2008-05-09 12:38 ` Stefan Roese [this message]
2008-05-09 14:51   ` Wolfgang Denk
2008-05-09 19:21     ` Stefan Roese
2008-05-09 22:40       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805091438.56226.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox