From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/4 V2] PPC: Change lib_ppc/bat_rw.c to use high bats
Date: Sat, 10 May 2008 01:07:32 +0200 [thread overview]
Message-ID: <20080509230732.BD08224764@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 09 May 2008 13:41:58 CDT." <6514CE95-5C25-4C36-88DA-63E03DE87024@freescale.com>
In message <6514CE95-5C25-4C36-88DA-63E03DE87024@freescale.com> you wrote:
>
> >> TLB entries */
> >> typedef enum {
> >> IBAT0 = 0, IBAT1, IBAT2, IBAT3,
> >> DBAT0, DBAT1, DBAT2, DBAT3
> >> +#ifdef CONFIG_HIGH_BATS
> >> + , IBAT4, IBAT5, IBAT6, IBAT7,
> >> + DBAT4, DBAT5, DBAT6, DBAT7
> >> +#endif
> >
> > C allows trailing commas on such lists; no need to move it inside the
> > ifdef.
>
> Dangling commas bother me in the extreme. If this is the concensus,
> I'll move it, but I prefer it where it is.
Please move it. As is it looks irregular and ugly to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: What do you get when you cross an ethernet with an income statement?
A: A local area networth.
prev parent reply other threads:[~2008-05-09 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 0:02 [U-Boot-Users] [PATCH 2/4 V2] PPC: Change lib_ppc/bat_rw.c to use high bats Becky.bruce at freescale.com
2008-05-09 15:28 ` Scott Wood
2008-05-09 18:41 ` Becky Bruce
2008-05-09 18:45 ` Jerry Van Baren
2008-05-09 19:14 ` Jean-Christophe PLAGNIOL-VILLARD
2008-05-09 19:38 ` Becky Bruce
2008-05-09 19:28 ` Stefan Roese
2008-05-09 19:39 ` Jerry Van Baren
2008-05-09 23:07 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509230732.BD08224764@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox