From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Sat, 10 May 2008 06:17:43 +0200 Subject: [U-Boot-Users] [RFC] [PATCH 2/2] [new uImage] Avoid initrd and logbuffer area overlaps In-Reply-To: <20080507110859.10627.96876.stgit@hekate.izotz.org> References: <20080507110850.10627.64684.stgit@hekate.izotz.org> <20080507110859.10627.96876.stgit@hekate.izotz.org> Message-ID: <200805100617.43643.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 07 May 2008, Marian Balakowicz wrote: > Add logbuffer to reserved LMB areas to prevent initrd allocation > from overlaping with it. > > Make sure to use correct logbuffer base address. > > Signed-off-by: Marian Balakowicz Hmmm, this patch breaks all PPC boards without logbuffer support. Take a look at "acadia" for example: [stefan at kubuntu u-boot (master)]$ ./MAKEALL acadia Configuring for acadia board... board.c: In function 'logbuffer_base': board.c:403: error: 'LOGBUFF_LEN' undeclared (first use in this function) board.c:403: error: (Each undeclared identifier is reported only once board.c:403: error: for each function it appears in.) make[1]: *** [board.o] Error 1 make: *** [lib_ppc/libppc.a] Error 2 I tried to quickly (#ifdef around the logbuffer_base() function in lib_ppc/board.c) fix it but it didn't work. So it would be great if you could come up with a fix for this. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================