From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alessandro Rubini <rubini-list@gnudd.com>
Date: Mon, 19 May 2008 22:44:36 +0200
Subject: [U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values
	in the MHZ range for NAND delays
In-Reply-To: <20080519201124.6F09D10376@mcmullan-linux.hq.netapp.com>
References: <20080519201124.6F09D10376@mcmullan-linux.hq.netapp.com> 
Message-ID: <20080519204436.GA3521@mail.gnudd.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


> +#if CFG_HZ > 100000

Shouldn't this be

	if (CFG_HZ > 100000)

instead?

It's a constant expression, and the compiler optimizes the conditional
out. Using if() instead of #if ensures that all the code is always parsed,
so the compiler can review it all and signal any problem. Not to mention
aesthetics.

/alessandro