[U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in the MHZ range for NAND delays

Wolfgang Denk
2008-05-19T20:38:24Z

In message <20080519201124.6F09D10376@mcmullan-linux.hq.netapp.com> you wrote:
> Rewrite the nand_wait() FL_ERASING case to handle CFG_HZ values in the
> MHZ range. This is needed for mips processors, as the timer's timebase
> ticks at CPU clock frequency.

NAK.

This is fundamentally broken, as CFG_HZ must not have "values in the
MHZ range'. Please consider it a constant with the value 1000.

Nonconforming ports should be fixed instead of adding code that
supports this brokenness.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Backed up the system lately?