[U-Boot-Users] [PATCH] Move conditional compilation of MPC8XXX SPI driver to Makefile

[Wolfgang Denk <wd@denx.de>]

In message <20080527093432.3026cb15@hskinnemo-gx745.norway.atmel.com> you wrote:
>
> This only makes a difference if a board config defines
> CONFIG_MPC8XXX_SPI without defining CONFIG_HARD_SPI, which is arguably
> a bug. I think it's better to get a compile error when this happens

I can't really folow that logic.

If we define CONFIG_HARD_SPI, then I don't see why CONFIG_MPC8XXX_SPI
is needed at all if we're on a MPC8XXX system - that seems  redundant
to  me.  On the other hand, if you want to use CONFIG_MPC8XXX_SPI and
this implies that CONFIG_HARD_SPI must be set, too,  then  it  should
automatically  set  this  variable  instead of causing the compile to
fail.

This assumes that we use only one SPI  controller  (built-in  on  the
CPU/SOC).  We  should  also  keep  in  mind what happens when you use
CONFIG_SOFT_SPI, eventually even simultaneously.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Pray: To ask that the laws of the universe be annulled in behalf of a
single petitioner confessedly unworthy.              - Ambrose Bierce