From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] From: Sergei Poselenov <sposelenov@emcraft.com>
Date: Wed, 28 May 2008 10:31:09 +0200 [thread overview]
Message-ID: <200805281031.09702.sr@denx.de> (raw)
In-Reply-To: <483D0F97.8010302@emcraft.com>
Hi Sergei,
On Wednesday 28 May 2008, Sergei Poselenov wrote:
> >> + if (gur->porpllsr & (1<<15)) {
> >
> > Please don't use pointer access for such SoC registers. in_be32() is
> > recommended here.
>
> What is the reason for doing this? Compiler issues? I see the direct
> pointer addressing is used all over the 85xx code.
Yes, I just noticed that these registers are accessed this way on (all?)
MPC85xx boards. So it is perhaps not a problem with these registers. Not sure
though, since I'm no MPC85xx expert. Perhaps somebody from FSL can comment
here.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-05-28 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 12:19 [U-Boot-Users] From: Sergei Poselenov <sposelenov@emcraft.com> Wolfgang Denk
2008-05-27 12:27 ` Jerry Van Baren
2008-05-27 18:52 ` Wolfgang Denk
2008-05-27 18:17 ` Stefan Roese
2008-05-28 7:53 ` Sergei Poselenov
2008-05-28 8:31 ` Stefan Roese [this message]
2008-05-28 16:14 ` Scott Wood
2008-06-04 22:06 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805281031.09702.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox