From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 28 May 2008 10:31:09 +0200
Subject: [U-Boot-Users] From: Sergei Poselenov <sposelenov@emcraft.com>
In-Reply-To: <483D0F97.8010302@emcraft.com>
References: <1211890770-20866-1-git-send-email-wd@denx.de>
	<200805272017.13595.sr@denx.de> <483D0F97.8010302@emcraft.com>
Message-ID: <200805281031.09702.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Sergei,

On Wednesday 28 May 2008, Sergei Poselenov wrote:
> >> +	if (gur->porpllsr & (1<<15)) {
> >
> > Please don't use pointer access for such SoC registers. in_be32() is
> > recommended here.
>
> What is the reason for doing this? Compiler issues? I see the direct 
> pointer addressing is used all over the 85xx code.

Yes, I just noticed that these registers are accessed this way on (all?) 
MPC85xx boards. So it is perhaps not a problem with these registers. Not sure 
though, since I'm no MPC85xx expert. Perhaps somebody from FSL can comment 
here.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================