From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Fri, 30 May 2008 12:28:42 -0500
Subject: [U-Boot-Users] [PATCH]env_nand.c Added bad block management	for
	environment variables
In-Reply-To: <c13b1cfc0805300814l77dec881w7f7fe32ff774baa6@mail.gmail.com>
References: <c13b1cfc0805270701s38288252k5de057bd96d8c856@mail.gmail.com>
	<20080528175704.GA3090@loki.buserror.net>
	<c13b1cfc0805291014l1c569e4icdb68b22df5fc8d6@mail.gmail.com>
	<483EE840.6030002@freescale.com> <483EE8CB.1060406@freescale.com>
	<c13b1cfc0805300814l77dec881w7f7fe32ff774baa6@mail.gmail.com>
Message-ID: <20080530172842.GA2950@loki.buserror.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, May 30, 2008 at 11:14:10AM -0400, Stuart Wood wrote:
> +int writeenv(size_t offset, u_char * buf)

No space after '*'.

> +			char_ptr = &buf[amount_saved];
> +			if (nand_write(&nand_info[0], offset, &blocksize, char_ptr)) {

Wrap long line.

> +				return 1;
> +			} else {

The "else" is superfluous.

> +		puts ("Erasing redundant Nand...\n");
> +		nand_erase(&nand_info[0], CFG_ENV_OFFSET_REDUND, CFG_ENV_RANGE);
> +

If erasing fails for reasons other than a bad block, we should abort.

If erasing fails due to a bad block, we should skip past it; however,
the current erase code fails and does not try to erase any further
blocks.  Use nand_erase_opts() instead.

> -	if (ret || total != CFG_ENV_SIZE)
> +	if (ret || total != CFG_ENV_SIZE) {
> +		puts("FAILED!\n");
>  		return 1;
> +	}

total is no longer referenced anywhere but here and the initialization;
remove it.

> +	while (amount_loaded < CFG_ENV_SIZE && offset < end) {
> +		if (nand_block_isbad(&nand_info[0], offset)) {
> +			offset += blocksize;
> +		} else {
> +			char_ptr = &buf[amount_loaded];
> +			nand_read(&nand_info[0], offset, &blocksize, char_ptr);

Please check the return value of nand_read.

-Scott