[U-Boot-Users] [PATCH 8/8] New board SIMPC8313 support: nand_boot.c, sdram.c, simpc8313.c

[Stefan Roese <sr@denx.de>]

Hi Ron,

On Friday 30 May 2008, Ron Madrid wrote:
> New board SIMPC8313 support: nand_boot.c, sdram.c,
> simpc8313.c
>
> Remaining board specific files.
>
> Signed-off-by: Ron Madrid
> ---
>  board/sheldon/simpc8313/nand_boot.c |  424
> +++++++++++++++++++++++++++++++++++
>  board/sheldon/simpc8313/sdram.c     |  204
> +++++++++++++++++
>  board/sheldon/simpc8313/simpc8313.c |  113 ++++++++++
>  3 files changed, 741 insertions(+), 0 deletions(-)
>  create mode 100644
> board/sheldon/simpc8313/nand_boot.c
>  create mode 100644 board/sheldon/simpc8313/sdram.c
>  create mode 100644
> board/sheldon/simpc8313/simpc8313.c
>
> diff --git a/board/sheldon/simpc8313/nand_boot.c

It seems that you duplicate some of the code already available in 
nand_spl/nand_boot.c. I assume that you took a look at this code, right? Why 
didn't you try to use this infrastructure for your NAND booting support?

The current nand_spl infrastructure is used on multiple PPC4xx boards and is 
designed to be platform independent. It's very likely that some changes for 
other platforms are needed though. One enhancements that come to my mind is:

- Automatic NAND chips detection (small- vs. big-page size)

One advantage of the current nand_spl subsystem is that it uses the same NAND 
board/platform driver as the "normal", full blown U-Boot NAND subsystem does. 
So there is no need to maintain multiple NAND drivers for one board/platform.

So again, please try to use the current nand_spl infrastructure. Or at least 
explain why it doesn't work for you, so that we can work on these problems.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================