From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 01 Jun 2008 22:14:01 +0200 Subject: [U-Boot-Users] [PATCH/review] Blackfin: add support for BF538/BF539 In-Reply-To: Your message of "Sun, 01 Jun 2008 01:38:44 EDT." <1212298724-15152-11-git-send-email-vapier@gentoo.org> Message-ID: <20080601201401.E9BAC247CC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <1212298724-15152-11-git-send-email-vapier@gentoo.org> you wrote: > Add initial support for the BF538 and BF539 Blackfin processors. > ... > diff --git a/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_cdef.h b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_cdef.h > new file mode 100644 > index 0000000..cba69f4 > --- /dev/null > +++ b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_cdef.h > @@ -0,0 +1,3343 @@ > +/* DO NOT EDIT THIS FILE > + * Automatically generated by generate-cdef-headers.xsl > + * DO NOT EDIT THIS FILE > + */ Do we really (I mean: really, really!) need all the 3343 lines of this crap^H^H^H^Hstuff? What is the licensing of this file, and who is the Copyright holder? > diff --git a/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h > new file mode 100644 > index 0000000..4e36fb9 > --- /dev/null > +++ b/include/asm-blackfin/mach-bf538/ADSP-EDN-BF538-extended_def.h > @@ -0,0 +1,1121 @@ > +/* DO NOT EDIT THIS FILE > + * Automatically generated by generate-def-headers.xsl > + * DO NOT EDIT THIS FILE > + */ Do we really (I mean: really, really!) need all the 1121 lines of this crap^H^H^H^Hstuff? What is the licensing of this file, and who is the Copyright holder? Please use tabs for indentation and alignment!! > diff --git a/include/asm-blackfin/mach-bf538/BF538_cdef.h b/include/asm-blackfin/mach-bf538/BF538_cdef.h > new file mode 100644 > index 0000000..c866740 > --- /dev/null > +++ b/include/asm-blackfin/mach-bf538/BF538_cdef.h > @@ -0,0 +1,14 @@ > +/* DO NOT EDIT THIS FILE > + * Automatically generated by generate-cdef-headers.xsl > + * DO NOT EDIT THIS FILE > + */ What is the licensing of this file, and who is the Copyright holder? > diff --git a/include/asm-blackfin/mach-bf538/BF538_def.h b/include/asm-blackfin/mach-bf538/BF538_def.h > new file mode 100644 > index 0000000..edeba2e > --- /dev/null > +++ b/include/asm-blackfin/mach-bf538/BF538_def.h > @@ -0,0 +1,29 @@ > +/* DO NOT EDIT THIS FILE > + * Automatically generated by generate-def-headers.xsl > + * DO NOT EDIT THIS FILE > + */ What is the licensing of this file, and who is the Copyright holder? ...and so on for the other, similar files. Hm.... looking at such a file is horrible: > +#define bfin_read_MXVR_PLL_CTL_0() bfin_read32(MXVR_PLL_CTL_0) > +#define bfin_write_MXVR_PLL_CTL_0(val) bfin_write32(MXVR_PLL_CTL_0, val) > +#define pMXVR_STATE_0 ((uint32_t volatile *)MXVR_STATE_0) /* MXVR State Register 0 */ > +#define bfin_read_MXVR_STATE_0() bfin_read32(MXVR_STATE_0) > +#define bfin_write_MXVR_STATE_0(val) bfin_write32(MXVR_STATE_0, val) > +#define pMXVR_STATE_1 ((uint32_t volatile *)MXVR_STATE_1) /* MXVR State Register 1 */ > +#define bfin_read_MXVR_STATE_1() bfin_read32(MXVR_STATE_1) > +#define bfin_write_MXVR_STATE_1(val) bfin_write32(MXVR_STATE_1, val) > +#define pMXVR_INT_STAT_0 ((uint32_t volatile *)MXVR_INT_STAT_0) /* MXVR Interrupt Status Register 0 */ > +#define bfin_read_MXVR_INT_STAT_0() bfin_read32(MXVR_INT_STAT_0) I do not think that we should allow such code in U-Boot. I do not want to see this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de 8 Catfish = 1 Octo-puss