public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset
Date: Mon, 02 Jun 2008 00:07:04 +0200	[thread overview]
Message-ID: <20080601220704.615842430A@gemini.denx.de> (raw)
In-Reply-To: Your message of "Sun, 01 Jun 2008 17:20:43 EDT." <200806011720.43991.vapier@gentoo.org>

In message <200806011720.43991.vapier@gentoo.org> you wrote:
>
> it's dead code because the current silicon is broken.  i know the code works 
> as ive tested it in scenarios where the anomaly isnt triggered, it just cant 
> be enabled until fixed hardware is released.  it's much easier to go back and 
> fix 1 if statement then have to carry this patch somewhere it can got lost
> and i need to waste time and rewrite it.

I don't want to add such dead code. Please resubmit when it is really
used.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real computer scientists don't comment their  code.  The  identifiers
are so long they can't afford the disk space.

  reply	other threads:[~2008-06-01 22:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-01  5:38 [U-Boot-Users] [PATCH/review] Blackfin: dont call i2c_init() from board_init_r() Mike Frysinger
2008-06-01  5:38 ` [U-Boot-Users] [PATCH/review] Blackfin: protect default flash according to CFG_MONITOR_LEN Mike Frysinger
2008-06-01  5:38   ` [U-Boot-Users] [PATCH/review] Blackfin: update proc headers from toolchain Mike Frysinger
2008-06-01  5:38     ` [U-Boot-Users] [PATCH/review] Blackfin: unify cache handling code Mike Frysinger
2008-06-01  5:38       ` [U-Boot-Users] [PATCH/review] Blackfin: use common memcpy routine during init Mike Frysinger
2008-06-01  5:38         ` [U-Boot-Users] [PATCH/review] Blackfin: enable support for nested interrupts Mike Frysinger
2008-06-01  5:38           ` [U-Boot-Users] [PATCH/review] Blackfin: respect CONFIG_CLKIN_HALF Mike Frysinger
2008-06-01  5:38             ` [U-Boot-Users] [PATCH/review] Blackfin: setup a sane default EBIU_SDBCTL for SDRAM controllers Mike Frysinger
2008-06-01  5:38               ` [U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() rom function when available Mike Frysinger
2008-06-01  5:38                 ` [U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset Mike Frysinger
2008-06-01  5:38                   ` [U-Boot-Users] [PATCH/review] Blackfin: add support for BF538/BF539 Mike Frysinger
2008-06-01 20:14                     ` Wolfgang Denk
2008-06-01 21:18                       ` Mike Frysinger
2008-06-01 22:05                         ` Wolfgang Denk
2008-06-01 23:03                           ` Mike Frysinger
2008-06-04  8:56                             ` Detlev Zundel
2008-06-04 10:18                               ` Mike Frysinger
2008-06-04 17:36                                 ` Detlev Zundel
2008-06-04 20:16                                   ` Mike Frysinger
2008-06-05 13:13                                     ` Detlev Zundel
2008-06-05 13:24                                     ` Wolfgang Denk
2008-06-01 19:56                   ` [U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset Wolfgang Denk
2008-06-01 21:20                     ` Mike Frysinger
2008-06-01 22:07                       ` Wolfgang Denk [this message]
2008-06-04  9:05                       ` Detlev Zundel
2008-06-04 10:10                         ` Mike Frysinger
2008-06-01 19:54               ` [U-Boot-Users] [PATCH/review] Blackfin: setup a sane default EBIU_SDBCTL for SDRAM controllers Wolfgang Denk
2008-06-01 21:12                 ` Mike Frysinger
2008-06-01 21:59                   ` Wolfgang Denk
2008-06-01 22:49                     ` Mike Frysinger
2008-06-01 19:47   ` [U-Boot-Users] [PATCH/review] Blackfin: protect default flash according to CFG_MONITOR_LEN Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080601220704.615842430A@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox