From: Sascha Hauer <s.hauer@pengutronix.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch 05/17] U-Boot-V2:ARM: Introduce capability to havedifferent stack/malloc area
Date: Tue, 3 Jun 2008 17:24:10 +0200 [thread overview]
Message-ID: <20080603152410.GD897@pengutronix.de> (raw)
In-Reply-To: <8E8BB316C604E94AA019A54D0A5A82A201BB5325@dlee13.ent.ti.com>
On Tue, Jun 03, 2008 at 10:04:29AM -0500, Menon, Nishanth wrote:
> Sascha,
>
> > -----Original Message-----
> > From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
> > Sent: Tuesday, June 03, 2008 3:08 AM
> > To: Menon, Nishanth
> > Cc: u-boot-users at lists.sourceforge.net; Laurent Desnogues; dirk.behme at googlemail.com;
> > philip.balister at gmail.com; Gopinath, Thara; Kamat, Nishant; Syed Mohammed, Khasim
> > Subject: Re: [Patch 05/17] U-Boot-V2:ARM: Introduce capability to havedifferent stack/malloc area
> >
> > This patch rises an issue we currently have in U-Boot-v2: We have as
> > many stack/memory strategies as we have architectures :(
> >
> > Instead of modifying this for one architecture I would prefer something
> > like this (currently no implementation, only kconfig).
> > Would this solve your issues?
> Yes, :). Couple of minor comments though..
>
> > diff --git a/common/Kconfig b/common/Kconfig
> > index 79a3684..d764482 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -19,13 +19,66 @@ menu "General Settings "
> > config BOARDINFO
> > string
> >
> > +menu "memory layout "
> Curious: Why have the extra space? I see this in other places too.. it kind of messes up the defconfig with trailing spaces :(.
It's just to align the menu arrows nicely under each other in make
menuconfig.
>
> > +choice
> > + prompt "select stack base policy"
> s/stack/heap?
> > + depends on HAVE_CONFIGURABLE_MALLOC
> > +
> > +config MALLOC_BASE_DEFAULT
> > + bool
> > + prompt "place stack before U-Boot"
> s/stack/heap?
No, this is the processor stack...
> > +
> > +config MALLOC_BASE_FIXED
> > + bool
> > + prompt "manually assign a malloc base"
> > +
...while this is the malloc heap.
> > +endchoice
> > +
> > +endmenu
> > +
> Ack to the changes. This should be good for me.
>
> Regards,
> Nishanth Menon
>
--
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
next prev parent reply other threads:[~2008-06-03 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 16:26 [U-Boot-Users] [Patch 05/17] U-Boot-V2:ARM: Introduce capability to have different stack/malloc area Menon, Nishanth
2008-06-03 8:08 ` Sascha Hauer
2008-06-03 15:04 ` [U-Boot-Users] [Patch 05/17] U-Boot-V2:ARM: Introduce capability to havedifferent " Menon, Nishanth
2008-06-03 15:24 ` Sascha Hauer [this message]
2008-06-04 5:04 ` [U-Boot-Users] [Patch 05/17 Try 2] U-Boot-V2:ARM: Introduce capability tohavedifferent " Menon, Nishanth
2008-06-04 9:57 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603152410.GD897@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox