From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] The fdt boardsetup command criteria was not unique
Date: Mon, 9 Jun 2008 13:16:24 -0500 [thread overview]
Message-ID: <20080609181624.GB2907@loki.buserror.net> (raw)
In-Reply-To: <20080607162926.GA27072@cideas.com>
On Sat, Jun 07, 2008 at 12:29:26PM -0400, Jerry Van Baren wrote:
> diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c
> index ede65ae..8592128 100644
> --- a/common/cmd_fdt.c
> +++ b/common/cmd_fdt.c
> @@ -403,7 +403,8 @@ int do_fdt (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
> }
> #ifdef CONFIG_OF_BOARD_SETUP
> /* Call the board-specific fixup routine */
> - else if (argv[1][0] == 'b')
> + else if ((argv[1][0] == 'b') && (argv[1][1] == 'o') &&
> + (argv[1][2] == 'a'))
> ft_board_setup(fdt, gd->bd);
> #endif
strncmp() would be clearer...
-Scott
next prev parent reply other threads:[~2008-06-09 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 16:29 [U-Boot-Users] [PATCH] The fdt boardsetup command criteria was not unique Jerry Van Baren
2008-06-09 18:16 ` Scott Wood [this message]
2008-06-09 18:52 ` Jerry Van Baren
2008-06-10 1:05 ` [U-Boot-Users] [PATCH] Use strncmp() for the fdt command Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609181624.GB2907@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox