From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics
Date: Thu, 12 Jun 2008 11:58:35 +0200 [thread overview]
Message-ID: <200806121158.35699.sr@denx.de> (raw)
In-Reply-To: <20080612063703.EA109240E8@gemini.denx.de>
On Thursday 12 June 2008, Wolfgang Denk wrote:
> In message <C475A96A.FBA7%gerickson@nuovations.com> you wrote:
> > These are actually now used in cpu/ppc4xx/start.S and are probably
> > already included in the latest 4xx pull from Stefan. So, this patch might
> > be a no-op at this point.
>
> A slightly different version of this seems to have benn pulled in
> with your "ppc4xx: Enable Primordial Stack for 40x and Unify ECC
> Handling" patch (c821b5f120be), but note that we have for example two
> different implementations of EBC_BXCR_BAS_ENCODE in include/ppc405.h
> and include/ppc440.h - the include/ppc405.h was changed with your
> c821b5f120be commit, while the include/ppc440.h code is much older
> (63153492 from 3 years ago).
>
> Please check that this is as intended.
We should consolidate these defines into one version. No need to have them
defined multiple times, since the EBC IP core should be nearly identical on
405 and 440 systems. Perhaps somebody else (Grant?) will find the time to do
this soon. If not I'll add it to my list...
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2008-06-12 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 21:23 [U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics Grant Erickson
2008-06-11 23:00 ` Wolfgang Denk
2008-06-11 23:10 ` Grant Erickson
2008-06-12 6:37 ` Wolfgang Denk
2008-06-12 9:58 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806121158.35699.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox