public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Silent console enhancement patch
Date: Fri, 13 Jun 2008 08:41:16 +0200	[thread overview]
Message-ID: <20080613064116.46768248CE@gemini.denx.de> (raw)
In-Reply-To: Your message of "Thu, 12 Jun 2008 13:39:29 EDT." <48515F51.5030504@harris.com>

In message <48515F51.5030504@harris.com> you wrote:
> 
> The silent console as currently implemented is not silent if a board has been
> newly manufactured.  I.e., some messages are printed prior to being able to set
> the "silent" environment variable the first time.
> 
> The following patch adds a new configuration option,
> CONFIG_VERY_SILENT_CONSOLE, which modifies the behavior slightly.  If this
> option is selected, then the absence of the "silent" variable will result in
> a default behavior of "silent".  Also, if "silent" is set to "1", then the
> behavior will be "silent".  Only if a different value, say "0", is selected
> will the behavior be "verbose".
> 
> This patch doesn't change the behavior for any existing BSP's because they will
> not have selected the CONFIG_VERY_SILENT_CONSOLE option.

I consider this seriously confusing.

Also I don't see what your problem is, assuming you provide a valid
environment with your newly manufactured systems.

I thend to reject this patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it went on at this rate, in several billion  years  he'd  be  rich
beyond his wildest dreams!            - Terry Pratchett, _Soul Music_

  reply	other threads:[~2008-06-13  6:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 17:39 [U-Boot-Users] Silent console enhancement patch Steven A. Falco
2008-06-13  6:41 ` Wolfgang Denk [this message]
2008-06-13 13:34   ` Steven A. Falco
2008-06-14 21:48     ` Wolfgang Denk
2008-06-16 16:45       ` Steven A. Falco
2008-06-17  4:17         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080613064116.46768248CE@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox