public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Patch to clean up syntax highlighting
Date: Sun, 15 Jun 2008 16:56:56 +0200	[thread overview]
Message-ID: <20080615165656.0b693611@siona.local> (raw)
In-Reply-To: <48526499.6000804@ge.com>

On Fri, 13 Jun 2008 08:14:17 -0400
Jerry Van Baren <gerald.vanbaren@ge.com> wrote:

> Looking at the source code, its pretty ugly already.  Your change 
> doesn't make it any more ugly and it could be argued that it is slightly 
> less ugly (your patch removes the duplication of the "if( (...)" 
> statement).  I also don't see any alternative that would make the code 
> beautiful.  :-(

Actually, I think the following would be slightly cleaner:

#ifdef CONFIG_HAS_UID
# define HAS_UID	(1)
#else
# define HAS_UID	(0)
#endif

/* ... */

	if (((strcmp (name, "serial#") == 0)
			&& (!HAS_UID || (flag != 0xdeaf4add)))
		|| ((strcmp (name, "ethaddr") == 0)

(I may have miscounted the parentheses though...I certainly see the
need for working syntax highlighting on this code ;-)

Haavard

  parent reply	other threads:[~2008-06-15 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 17:24 [U-Boot-Users] Patch to clean up syntax highlighting Steven A. Falco
2008-06-13  3:55 ` Jerry Van Baren
2008-06-13 12:14   ` Jerry Van Baren
2008-06-13 13:38     ` Steven A. Falco
2008-06-15 14:56     ` Haavard Skinnemoen [this message]
2008-07-05 22:32 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080615165656.0b693611@siona.local \
    --to=haavard.skinnemoen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox