From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix printf errors.
Date: Mon, 07 Jul 2008 00:29:07 +0200 [thread overview]
Message-ID: <20080706222907.4F8DA24681@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 02 Jul 2008 07:17:40 PDT." <200807021417.m62EHeff016508@pogo.cesa.opbu.xerox.com>
In message <200807021417.m62EHeff016508@pogo.cesa.opbu.xerox.com> you wrote:
> The compiler will help find mismatches between printf formats and
> arguments if you let it. This patch adds the necessary attributes to
> declarations in include/common.h, then corrects the resulting compiler
> warnings in several files. Some of these were bugs, e.g., "$d"
> instead of "%d" and incorrect arguments in common/cmd_fdt.c. Others
> were just annoying, like int-long mismatches on a system where both
> are 32 bits. It's worth fixing the annoying errors to catch the real
> ones.
>
> I can only compile for ppc architecture so have not tested much of the
> source code for further warnings.
Very good. Thanks a lot - but could you please add your signed-off-by
line, and clean up the commit message (move commnets for the posting
that are not intended for the commit message _below_ the "---" line).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat. Deshalb mu? man das
Wahre unerm?dlich in Worten wiederholen. - Goethe
prev parent reply other threads:[~2008-07-06 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 14:17 [U-Boot-Users] [PATCH] Fix printf errors Andrew Klossner
2008-07-03 0:36 ` Jerry Van Baren
2008-07-06 22:29 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080706222907.4F8DA24681@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox