[U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST.

[U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST.

[sascha.laue at liebherr.com]

From: Sascha Laue <sascha.laue@liebherr.com>

Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
 board/lwmon5/lwmon5.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/board/lwmon5/lwmon5.c b/board/lwmon5/lwmon5.c
index b63fbdc..c29dfc1 100644
--- a/board/lwmon5/lwmon5.c
+++ b/board/lwmon5/lwmon5.c
@@ -24,6 +24,7 @@
 #include <asm/processor.h>
 #include <asm/gpio.h>
 #include <asm/io.h>
+#include <post.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -103,15 +104,17 @@ int board_early_init_f(void)
 	out_be32((void *)CFG_DSPIC_TEST_ADDR,
 		in_be32((void *)CFG_DSPIC_TEST_ADDR)
 			& ~CFG_DSPIC_TEST_MASK);
-	while (!gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
+	while (gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
 		udelay(1000);
 	}
-	gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
 	if (gpio_read_in_bit(CFG_GPIO_DSPIC_READY)) {
 		/* set "boot error" flag */
 		out_be32((void *)CFG_DSPIC_TEST_ADDR,
 			in_be32((void *)CFG_DSPIC_TEST_ADDR) |
 			CFG_DSPIC_TEST_MASK);
+	} else {
+		/* dspic ready - disable LSB transmitter */
+		gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
 	}
 #endif
 
-- 
1.5.2.4

[U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST.

[Wolfgang Denk]

In message <12121336692773-git-send-email-sascha.laue@liebherr.com> you wrote:
...
> -	while (!gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
> +	while (gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
>  		udelay(1000);
>  	}
> -	gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
>  	if (gpio_read_in_bit(CFG_GPIO_DSPIC_READY)) {
>  		/* set "boot error" flag */
>  		out_be32((void *)CFG_DSPIC_TEST_ADDR,
>  			in_be32((void *)CFG_DSPIC_TEST_ADDR) |
>  			CFG_DSPIC_TEST_MASK);
> +	} else {
> +		/* dspic ready - disable LSB transmitter */
> +		gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);

Description and patch don't match. Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
: ... and it's got weird formatting - Notepad, Write, Works  3  can't
: decipher it, and it's too big to go in DOS Edit. Help!
Install an operating system. :-)                  -- Tom Christiansen

[U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST.

[Stefan Roese]

On Friday 30 May 2008, Wolfgang Denk wrote:
> In message <12121336692773-git-send-email-sascha.laue@liebherr.com> you
> wrote: ...
>
> > -	while (!gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
> > +	while (gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
> >  		udelay(1000);
> >  	}
> > -	gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
> >  	if (gpio_read_in_bit(CFG_GPIO_DSPIC_READY)) {
> >  		/* set "boot error" flag */
> >  		out_be32((void *)CFG_DSPIC_TEST_ADDR,
> >  			in_be32((void *)CFG_DSPIC_TEST_ADDR) |
> >  			CFG_DSPIC_TEST_MASK);
> > +	} else {
> > +		/* dspic ready - disable LSB transmitter */
> > +		gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
>
> Description and patch don't match. Please fix.

Sascha, any updates here?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================