* [U-Boot-Users] [PATCH] Remove useless print message at apollon
@ 2008-07-08 0:08 Kyungmin Park
2008-07-09 22:41 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2008-07-08 0:08 UTC (permalink / raw)
To: u-boot
Remove useless print message at apollon
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/board/apollon/apollon.c b/board/apollon/apollon.c
index 7e39817..8efa703 100644
--- a/board/apollon/apollon.c
+++ b/board/apollon/apollon.c
@@ -153,10 +153,8 @@ void ether_init(void)
do {
__raw_writew(0x1, LAN_RESET_REGISTER);
udelay(100);
- if (cnt == 0) {
- printf("1. eth reset err\n");
+ if (cnt == 0)
goto eth_reset_err_out;
- }
--cnt;
} while (__raw_readw(LAN_RESET_REGISTER) != 0x1);
@@ -165,10 +163,8 @@ void ether_init(void)
do {
__raw_writew(0x0, LAN_RESET_REGISTER);
udelay(100);
- if (cnt == 0) {
- printf("2. eth reset err\n");
+ if (cnt == 0)
goto eth_reset_err_out;
- }
--cnt;
} while (__raw_readw(LAN_RESET_REGISTER) != 0x0000);
udelay(1000);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] Remove useless print message at apollon
2008-07-08 0:08 [U-Boot-Users] [PATCH] Remove useless print message at apollon Kyungmin Park
@ 2008-07-09 22:41 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2008-07-09 22:41 UTC (permalink / raw)
To: u-boot
In message <20080708000840.GA7562@july> you wrote:
> Remove useless print message at apollon
Please do NOT repeat the firtst line of the commit message (already in
Subject: )
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/board/apollon/apollon.c b/board/apollon/apollon.c
> index 7e39817..8efa703 100644
> --- a/board/apollon/apollon.c
> +++ b/board/apollon/apollon.c
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the bathtub of history the truth is harder to hold than the soap,
and much more difficult to find ... - Terry Pratchett, _Sourcery_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-09 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-08 0:08 [U-Boot-Users] [PATCH] Remove useless print message at apollon Kyungmin Park
2008-07-09 22:41 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox