[U-Boot-Users] [PATCH 1/2] fdt_support: fdt_fixup_dr_usb: add support for phy_type fixups

[U-Boot-Users] [PATCH 1/2] fdt_support: fdt_fixup_dr_usb: add support for phy_type fixups

[Anton Vorontsov]

Currently U-Boot can only fixup the usb dr_mode, but some boards (namely
MPC8315E-RDB) can use two PHY types: ULPI (stand-alone OTG port) or UTMI
(connected to the four-ports hub, usb host only).

This patch implements support for passing Dual-Role USB controller's
device tree property phy_type through the usb_phy_type environment
variable.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 common/fdt_support.c |   30 +++++++++++++++++++++++-------
 1 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3828228..24bbed0 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -422,23 +422,39 @@ void fdt_fixup_ethernet(void *fdt, bd_t *bd)
 void fdt_fixup_dr_usb(void *blob, bd_t *bd)
 {
 	char *mode;
+	char *type;
 	const char *compat = "fsl-usb2-dr";
-	const char *prop = "dr_mode";
+	const char *prop_mode = "dr_mode";
+	const char *prop_type = "phy_type";
 	int node_offset;
 	int err;
 
 	mode = getenv("usb_dr_mode");
-	if (!mode)
+	type = getenv("usb_phy_type");
+	if (!mode && !type)
 		return;
 
 	node_offset = fdt_node_offset_by_compatible(blob, 0, compat);
-	if (node_offset < 0)
+	if (node_offset < 0) {
 		printf("WARNING: could not find compatible node %s: %s.\n",
 			compat, fdt_strerror(node_offset));
+		return;
+	}
 
-	err = fdt_setprop(blob, node_offset, prop, mode, strlen(mode) + 1);
-	if (err < 0)
-		printf("WARNING: could not set %s for %s: %s.\n",
-		       prop, compat, fdt_strerror(err));
+	if (mode) {
+		err = fdt_setprop(blob, node_offset, prop_mode, mode,
+				  strlen(mode) + 1);
+		if (err < 0)
+			printf("WARNING: could not set %s for %s: %s.\n",
+			       prop_mode, compat, fdt_strerror(err));
+	}
+
+	if (type) {
+		err = fdt_setprop(blob, node_offset, prop_type, type,
+				  strlen(type) + 1);
+		if (err < 0)
+			printf("WARNING: could not set %s for %s: %s.\n",
+			       prop_type, compat, fdt_strerror(err));
+	}
 }
 #endif /* CONFIG_HAS_FSL_DR_USB */
-- 
1.5.5.4

[U-Boot-Users] [PATCH 1/2] fdt_support: fdt_fixup_dr_usb: add support for phy_type fixups

[Jerry Van Baren]

Anton Vorontsov wrote:
> Currently U-Boot can only fixup the usb dr_mode, but some boards (namely
> MPC8315E-RDB) can use two PHY types: ULPI (stand-alone OTG port) or UTMI
> (connected to the four-ports hub, usb host only).
> 
> This patch implements support for passing Dual-Role USB controller's
> device tree property phy_type through the usb_phy_type environment
> variable.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>  common/fdt_support.c |   30 +++++++++++++++++++++++-------
>  1 files changed, 23 insertions(+), 7 deletions(-)
> 
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index 3828228..24bbed0 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c

Hi Anton, Kim,

This looks good to me.

Anton, I presume this is additional functionality for the next window,
not a bug fix for the current (closed) window?

Kim, would you like to apply this as well as [PATCH 2/2] through the
83xx repository so the two halves go in at the same time?

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

Thanks,
gvb

[U-Boot-Users] [PATCH 1/2] fdt_support: fdt_fixup_dr_usb: add support for phy_type fixups

[Anton Vorontsov]

On Tue, Jul 08, 2008 at 08:38:37PM -0400, Jerry Van Baren wrote:
> Anton Vorontsov wrote:
>> Currently U-Boot can only fixup the usb dr_mode, but some boards (namely
>> MPC8315E-RDB) can use two PHY types: ULPI (stand-alone OTG port) or UTMI
>> (connected to the four-ports hub, usb host only).
>>
>> This patch implements support for passing Dual-Role USB controller's
>> device tree property phy_type through the usb_phy_type environment
>> variable.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>>  common/fdt_support.c |   30 +++++++++++++++++++++++-------
>>  1 files changed, 23 insertions(+), 7 deletions(-)
>>
>> diff --git a/common/fdt_support.c b/common/fdt_support.c
>> index 3828228..24bbed0 100644
>> --- a/common/fdt_support.c
>> +++ b/common/fdt_support.c
>
> Hi Anton, Kim,
>
> This looks good to me.
>
> Anton, I presume this is additional functionality for the next window,  
> not a bug fix for the current (closed) window?

No, this isn't a bug fix. Just a new feature for the next window.

> Kim, would you like to apply this as well as [PATCH 2/2] through the  
> 83xx repository so the two halves go in at the same time?
>
> Acked-by: Gerald Van Baren <vanbaren@cideas.com>

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2

[U-Boot-Users] [PATCH 1/2] fdt_support: fdt_fixup_dr_usb: add support for phy_type fixups

[Kim Phillips]

On Tue, 08 Jul 2008 20:49:21 -0400
Jerry Van Baren <gvb.uboot@gmail.com> wrote:

Hi Jerry,

> Kim, would you like to apply this as well as [PATCH 2/2] through the
> 83xx repository so the two halves go in at the same time?

with this:

> Acked-by: Gerald Van Baren <vanbaren@cideas.com>

yes!  Both patches now sitting on u-boot-mpc83xx.git's 'next' branch.

Thank you both,

Kim