From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] cpu/mpc85xx/fdt.c forcing incorrect UART clock into fdt.
Date: Wed, 9 Jul 2008 13:08:28 -0400 [thread overview]
Message-ID: <20080709170824.GA9894@windriver.com> (raw)
In-Reply-To: <3FF89EF0-D40D-4DB2-B8CD-83A22E4C8806@kernel.crashing.org>
In message: Re: [U-Boot-Users] cpu/mpc85xx/fdt.c forcing incorrect UART clock into fdt.
on 09/07/2008 Kumar Gala wrote:
>
> On Jul 8, 2008, at 4:42 PM, Paul Gortmaker wrote:
>
>>
>> I fixed it with this simple patch, but I was wondering whether it
>> would
>> be better to alternatively just check if the dtb value is zero, and
>> then only insert a value; otherwise leave it alone...
>
> I think that should be left up to a board to decide, but in general it
> seems like doing the setting unconditionally is ok, we just didn't
> handle the case you had and the patch address it.
OK, so that we only end up changing just one thing at a time, I'll
spin a proper patch which just makes the NS16550_CLK change, and
we can change the create flag as per Jerry's comment at a later date
if required.
In the interest of consistency, I've make the same change for 83xx and
86xx as well, since the code is pretty much identical, and a MAKEALL
shows no boards failing due to a non-defined NS16550_CLK. Patch to
follow shortly...
Thanks,
Paul.
>
> - k
next prev parent reply other threads:[~2008-07-09 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 21:42 [U-Boot-Users] cpu/mpc85xx/fdt.c forcing incorrect UART clock into fdt Paul Gortmaker
2008-07-09 11:59 ` Jerry Van Baren
2008-07-09 12:52 ` Kumar Gala
2008-07-09 17:08 ` Paul Gortmaker [this message]
2008-07-09 17:04 ` Jerry Van Baren
2008-07-09 17:23 ` [U-Boot-Users] [PATCH] 8xxx-fdt: set ns16550 clock from CFG_NS16550_CLK, not bi_busfreq Paul Gortmaker
2008-07-09 18:43 ` Paul Gortmaker
2008-07-09 21:53 ` Kim Phillips
2008-07-15 0:00 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709170824.GA9894@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox