From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Wed, 9 Jul 2008 13:08:28 -0400
Subject: [U-Boot-Users] cpu/mpc85xx/fdt.c forcing incorrect UART
	clock	into fdt.
In-Reply-To: <3FF89EF0-D40D-4DB2-B8CD-83A22E4C8806@kernel.crashing.org>
References: <20080708214229.GA25621@windriver.com>
	<3FF89EF0-D40D-4DB2-B8CD-83A22E4C8806@kernel.crashing.org>
Message-ID: <20080709170824.GA9894@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

In message: Re: [U-Boot-Users] cpu/mpc85xx/fdt.c forcing incorrect UART clock into fdt.
on 09/07/2008 Kumar Gala wrote:

>
> On Jul 8, 2008, at 4:42 PM, Paul Gortmaker wrote:
>
>>
>> I fixed it with this simple patch, but I was wondering whether it  
>> would
>> be better to alternatively just check if the dtb value is zero, and
>> then only insert a value; otherwise leave it alone...
>
> I think that should be left up to a board to decide, but in general it  
> seems like doing the setting unconditionally is ok, we just didn't  
> handle the case you had and the patch address it.

OK, so that we only end up changing just one thing at a time, I'll
spin a proper patch which just makes the NS16550_CLK change, and
we can change the create flag as per Jerry's comment at a later date
if required.

In the interest of consistency, I've make the same change for 83xx and
86xx as well, since the code is pretty much identical, and a MAKEALL
shows no boards failing due to a non-defined NS16550_CLK.  Patch to
follow shortly...

Thanks,
Paul.

>
> - k